Skip to content

wait until processImpl completes before closing stream chan #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmerkulov wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −0
Open

wait until processImpl completes before closing stream chan #1677

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fad9519
wait untill processImpl completes before closing stream chan
nmerkulov Oct 6, 2025
6929fe6
Merge branch 'main' into fix-process-query-channel-race
kavirajk Oct 15, 2025
24bbc84
Merge branch 'main' into fix-process-query-channel-race
kavirajk Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions conn_process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,11 @@ func (c *connect) process(ctx context.Context, on *onProcess) error {
select {
case <-ctx.Done():
c.cancel()
// Wait for goroutine to finish before returning
select {
Copy link
Copy Markdown
Contributor

@kavirajk kavirajk Dec 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bit of concern with this approach is, if you look at the background goroutine, it doesn't use/watch for passed in ctx for cancellation. It does give it to upstream handle method but we cannot gurantee that handle returns as soon as passed in ctx get cancelled.

the problem is, the whole point of canceling this method is to stop doing handle and return immediately.

With this change, we may indirectly may end-up waiting for handle to "finish".

I would handle the situation ideally like following.

  1. make the goroutine listen with two select case. a. handle to finish b. context to be done.
  2. Based on which ever comes first (a) or (b), we exit the go-routine.

Does it make sense?

Copy link
Copy Markdown
Contributor

@kavirajk kavirajk Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we may have same problem during firstBlock as well
https://github.com/nmerkulov/clickhouse-go/blob/24bbc84a5899c097a66469e063b3ddb3eba39045/conn_process.go#L30-L46

case <-errCh:
case <-doneCh:
}
Comment on lines +119 to +123
Copy link

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'untill' to 'until' in the PR title.

Copilot uses AI. Check for mistakes.
return ctx.Err()

case err := <-errCh:
Expand Down
Loading