Skip to content

Fix eager eval of non-Field broadcasts in calc_level_val #2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imreddyTeja merged 2 commits into from
Apr 23, 2026
+44 −2
Merged

Fix eager eval of non-Field broadcasts in calc_level_val #2494

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84db859
Fix eager eval of non-Field broadcasts in calc_level_val
imreddyTeja Apr 21, 2026
3d18a61
Add test for stencil with non AbstractFieldStyle broadcasts
imreddyTeja Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/cuda/operators_fd_eager.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import ClimaCore: Spaces, Quadratures, Topologies, Operators
import Base.Broadcast: Broadcasted
import ClimaCore.Fields: Field, field_values
import ClimaCore.Fields: Field, field_values, AbstractFieldStyle
import ClimaComms
import ClimaCore.Utilities: half
import ClimaCore.Operators
Expand Down Expand Up @@ -204,7 +204,7 @@ Base.@propagate_inbounds reconstruct_space_and_call_calc_level_val(
arg::A,
space::S,
) where {
A <: Union{Base.Broadcast.Broadcasted, StencilBroadcasted, Field},
A <: Union{Base.Broadcast.Broadcasted{<:AbstractFieldStyle}, StencilBroadcasted, Field},
S,
} = @inbounds @inline calc_level_val(arg, reconstruct_placeholder_space(axes(arg), space))
Comment thread
imreddyTeja marked this conversation as resolved.
Base.@propagate_inbounds reconstruct_space_and_call_calc_level_val(
Expand Down
Loading