Use columnwise for setting tendencies to zero#3852
Closed
charleskawczynski wants to merge 1 commit into
Closed
Conversation
charleskawczynski
requested review from
dennisYatunin,
glwagner,
haakon-e,
oalcabes,
ray-chew and
trontrytel
charleskawczynski
force-pushed
the
ck/columnwise_set_zero
branch
2 times, most recently
from
5f0c9c1 to
8ccab2a
Compare
glwagner
reviewed
Jun 16, 2025
glwagner
reviewed
Jun 16, 2025
glwagner
reviewed
Jun 16, 2025
| ##### | ||
| ##### Cell center tendencies | ||
| ##### | ||
| function ᶜremaining_tendency(ᶜY, ᶠY, p, t) |
Member
There was a problem hiding this comment.
I can't figure out what this function does by its name so a docstring might help
Member
Author
There was a problem hiding this comment.
Yeah, I'll add one for this and the other top-level one that is passed to columnwise!.
glwagner
reviewed
Jun 16, 2025
Member
glwagner
left a comment
glwagner
left a comment
There was a problem hiding this comment.
I don't feel qualified to deliver an authoritative review, so I've made a few comments about aesthetics.
Update src/utils/utilities.jl Co-authored-by: Gregory L. Wagner <[email protected]> Update src/utils/utilities.jl Co-authored-by: Gregory L. Wagner <[email protected]>
charleskawczynski
force-pushed
the
ck/columnwise_set_zero
branch
from
a4cf9df to
b3f3351
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not getting much traction on #3833, so I'll open one more PR along these lines. This PR uses
columnwise!to setYₜto zero. I've tried to cleanup / document functions so that this PR will pass CI and is merge-able.