Skip to content

refactor: optimize username cloning for Unix processes #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ClementTsang merged 7 commits into from
Sep 15, 2025

ugh

aaa69b4
Select commit
Loading
Failed to load commit list.
Merged

refactor: optimize username cloning for Unix processes #1816

ugh
aaa69b4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 15, 2025 in 1s

43.48% (-0.05%) compared to c8614bf

View this Pull Request on Codecov

43.48% (-0.05%) compared to c8614bf

Details

Codecov Report

❌ Patch coverage is 11.53846% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.48%. Comparing base (c8614bf) to head (aaa69b4).

Files with missing lines Patch % Lines
src/widgets/process_table/process_data.rs 9.09% 10 Missing ⚠️
src/widgets/process_table/process_columns.rs 0.00% 4 Missing ⚠️
src/collection/processes/unix/user_table.rs 0.00% 3 Missing ⚠️
src/widgets/process_table/query.rs 0.00% 3 Missing ⚠️
src/collection/processes/linux/mod.rs 0.00% 1 Missing ⚠️
src/collection/processes/unix/process_ext.rs 0.00% 1 Missing ⚠️
src/collection/processes/windows.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1816      +/-   ##
==========================================
- Coverage   43.53%   43.48%   -0.05%     
==========================================
  Files         115      115              
  Lines       16302    16297       -5     
==========================================
- Hits         7097     7087      -10     
- Misses       9205     9210       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov