Upd. Scan. Improve flow to reduce gathering unneeded data. - #703
Open
svfcode wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR streamlines the malware scan “send results” flow by removing the collection (and related DTO plumbing) of “unknown files” data that wasn’t being used in the outgoing security_mscan_logs API request, reducing unnecessary DB reads and payload preparation work.
Changes:
- Removed gathering of “unknown files” scan results from
SendResultsStage::gatherFileData(). - Deleted the unused
UnknownRepositoryimplementation. - Removed the
unknownproperty fromSendFilesDTOsince it’s no longer populated.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/CleantalkSP/SpbctWP/Scanner/Stages/SendResultsStage.php | Stops fetching/attaching unknown-file results during scan result sending. |
| lib/CleantalkSP/SpbctWP/Scanner/Stages/Repositories/UnknownRepository.php | Removes the repository used to query unknown files for sending results. |
| lib/CleantalkSP/SpbctWP/Scanner/Stages/DTO/SendFilesDTO.php | Drops the now-unused unknown DTO field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task https://app.doboard.com/1/task/38166