feat(manifests): add idle-detector to default-workflows - #5782
Open
chronoai-shining wants to merge 1 commit into
Open
feat(manifests): add idle-detector to default-workflows#5782chronoai-shining wants to merge 1 commit into
chronoai-shining wants to merge 1 commit into
Conversation
The mandatory package baseline (fkst-hosted #5773/#5780) requires every session to declare github-proxy, workflow-dev, workflow-writer, idle-detector and fkst-health. This manifest carried four of the five, so once the baseline is enforced every manifest-driven session -- which is most of them, including the sessions currently running -- would be refused for the one it lacks. Caught while preparing the prod deploy, before enabling FKST_MANDATORY_PACKAGES. idle-detector is platform baseline rather than workflow topology: it emits system_idle so a session with no work idles its pod down. Appended beside fkst-health, which is in this manifest for the same reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The mandatory package baseline (#5773, #5780) requires every session to declare five refs.
default-workflows.jsoncarried four —idle-detectorwas missing.Most sessions are manifest-driven, so enforcing the baseline without this would refuse nearly every session on the platform, including the ones currently running.
Caught while preparing the prod deploy, before enabling
FKST_MANDATORY_PACKAGES.Why it belongs here
idle-detectoris platform baseline rather than workflow topology — it emitssystem_idleso a session with no work idles its pod down. Appended besidefkst-health, which is in this manifest for the same reason.Verified the manifest now satisfies all five mandatory refs exactly.