20260805 classic codegen - #553
Open
prozacchiwawa wants to merge 40 commits into
Open
Conversation
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
This reverts commit 4343043.
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 299c335. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
High Risk
Large refactor of the classic compilation pipeline with new language features (&rest, @env, modern com assembly) that can change generated CLVM and error reporting across many code paths.
Overview
Introduces a
ClassicAllocatorabstraction (withClErrorcarryingSrcloc) andSExpClassicAllocator, which keeps modern compiler S-expressions and raw CLVM nodes in sync so stage-2 can report source locations instead of onlyNodePtr-basedEvalErr.Stage-2
com,mod, pattern matching, and sharedsexphelpers are generalized over that trait;compile_applicationgains&resttail handling, anddefun-inlinecan reference@*env*via new inline-environment lowering.For strict/modern dialects,
comnow runsassemble_com_programto turn symbolic operator heads (e.g.q) into numeric opcodes while preserving per-subexpression locations;@*env*is also recognized like@during symbol transformation.CI updates
mandelbrot-cldb.pywith optional sigil substitution and YAML-based output comparison (pluspyyamlin the workflow).Reviewed by Cursor Bugbot for commit 5299534. Bugbot is set up for automated code reviews on this repo. Configure here.