Conversation
flake8 7.2.0 (pyflakes 3.3.2) flags nonlocal names that are only read and never assigned in their scope. Drop the unused names from the declarations in _update_timing and _prompt_for_upgrade.
stop_logging() only deleted the listener, which never unblocked the blocking start() call, so the listener thread hung and prevented a clean exit. Call listener.stop() (new in vinput 1.3.0) and join the listener thread before freeing it.
Signal handlers are invoked with (signum, frame); the one-arg lambda raised TypeError before ever calling stop_logging, so Ctrl-C never stopped the listener. Accept and ignore both arguments.
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s Python dependencies and makes small runtime fixes to improve shutdown behavior and signal handling in the freqlog component.
Changes:
- Bumped development/test dependencies (flake8/pytest/pytest-cov/pre-commit) and runtime dependencies (PyInstaller/PySide6/requests/vinput).
- Adjusted packaging dependency for
vinputinsetup.cfg. - Improved freqlog shutdown by stopping the listener and joining its thread; fixed SIGINT handler signature in CLI entrypoint.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test-requirements.txt | Updates test/dev tool versions. |
| setup.cfg | Tightens/updates packaged dependency on vinput. |
| requirements.txt | Updates runtime dependency versions (incl. vinput). |
| nexus/Freqlog/Freqlog.py | Improves listener shutdown to avoid hanging threads. |
| nexus/main.py | Fixes SIGINT handler signature to accept (signum, frame). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
61
to
+63
| install_requires = | ||
| setuptools | ||
| vinput | ||
| vinput>=1.3.0 |
Comment on lines
392
to
403
| self.killed = True | ||
| logging.warning("Stopping freqlog") | ||
| if self.listener: | ||
| # stop() unblocks the listener's blocking start() call so its thread can | ||
| # return; without it the listener thread would hang and prevent a clean | ||
| # shutdown. Wait for the thread to exit before freeing the listener. | ||
| self.listener.stop() | ||
| if self.listener_thread.is_alive(): | ||
| self.listener_thread.join() | ||
| del self.listener | ||
| self.listener = None | ||
| self.is_logging = False |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.