Merged
Conversation
…7118) Include skipped partial withdrawal to count
* initial commit * process deposits on epoch processing * lint * Fix spec test * Remove commented out code * Update packages/state-transition/src/epoch/processPendingDeposits.ts Co-authored-by: twoeths <tuyen@chainsafe.io> * Address comments * lint --------- Co-authored-by: twoeths <tuyen@chainsafe.io>
* Pass execution requests in bytes * lint
* initial commit * Update packages/beacon-node/src/chain/produceBlock/produceBlockBody.ts Co-authored-by: Nico Flaig <nflaig@protonmail.com> --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7154 +/- ##
============================================
- Coverage 49.21% 49.18% -0.04%
============================================
Files 598 598
Lines 39726 39770 +44
Branches 2092 2097 +5
============================================
+ Hits 19550 19559 +9
- Misses 20136 20170 +34
- Partials 40 41 +1 |
* New compound switching logic * clean up * fix: remove newCompoundingValidators in EpochTransitionCache * Bump spec version * Address comment * address comment * Lint --------- Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
* chore: clean up single-used function * Remove Uint8Array * Present state-transition constants in Uint8Array
Member
|
we should probably forward merge this into unstable instead of squashing it |
g11tech
reviewed
Oct 14, 2024
Contributor
g11tech
left a comment
g11tech
left a comment
There was a problem hiding this comment.
did a cursory, looks good to me
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Contributor
Author
It will be hard since the PR has a mix of direct commits and commits from other PRs. The easiest way is to squash the commits, and just reference the other PRs in the description of this PR. |
ensi321
commented
Oct 17, 2024
| @@ -25,12 +31,19 @@ describe("Ensure config is synced", () => { | |||
| }); | |||
|
|
|||
| function assertCorrectPreset(localPreset: BeaconPreset, remotePreset: BeaconPreset): void { | |||
Contributor
Author
There was a problem hiding this comment.
Remote preset is missing MAX_BLOBS_PER_BLOCK since it has moved to config. But Lodestar has not made it configurable and it remains in local config.
Adding ignoredLocalPresetFields is a temporary workaround to make this test pass such that this PR is safe to be merged into unstable.
See #7172 for details
| } | ||
| } else { | ||
| if (fork < ForkSeq.electra) { | ||
| const isNewValidator = cachedIndex === null || !Number.isSafeInteger(cachedIndex) || cachedIndex >= validators.length; |
Contributor
Author
There was a problem hiding this comment.
We need to add back condition cachedIndex >= validators.length to pass the benchmark check. @twoeths
Member
There was a problem hiding this comment.
Benchmark seems to pass, is this still an issue?
Contributor
Author
There was a problem hiding this comment.
Benchmark seems to pass, is this still an issue?
It is passing because I added back this condition
Member
We can squash those extra commits in this PR before merging |
nflaig
reviewed
Oct 17, 2024
Member
yes pls |
nflaig
approved these changes
Oct 18, 2024
Member
|
🎉 This PR is included in v1.23.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes all necessary consensus spec changes versioned
v1.5.0-alpha.7andv1.5.0-alpha.8. Also implements Electra builder specs.partialWithdrawalsCountfix: include skipped partial withdrawal topartialWithdrawalsCount#7118