Skip to content

fix: improve atomic ordering in ThreadPool and NAPI init #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GrapeBaBa wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: improve atomic ordering in ThreadPool and NAPI init #310

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f74629
fix: improve atomic ordering in ThreadPool and NAPI init
GrapeBaBa Apr 10, 2026
6860e0e
fix: guard NAPI cleanup hook with init_mutex and assert errdefer inva…
GrapeBaBa Apr 10, 2026
8f3666f
Merge branch 'main' into worktree-fix+atomic-ordering
GrapeBaBa May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/bls/ThreadPool.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,6 @@ const VerifyMultiWorkItem = struct {
const self: *VerifyMultiWorkItem = @fieldParentPtr("base", base_item);
const job = self.job;

// Each worker gets its own pairing buffer on the stack
var buf: PairingBuf = .{};
var pairing = Pairing.init(&buf.data, true, job.dst);

Expand All @@ -210,7 +209,7 @@ const VerifyMultiWorkItem = struct {
while (true) {
const i = job.counter.fetchAdd(1, .monotonic);
if (i >= n_elems) break;
if (job.err_flag.load(.acquire)) break;
if (job.err_flag.load(.monotonic)) break;

did_work = true;

Expand Down Expand Up @@ -344,7 +343,7 @@ const AggVerifyWorkItem = struct {
while (true) {
const i = job.counter.fetchAdd(1, .monotonic);
if (i >= job.n_elems) break;
if (job.err_flag.load(.acquire)) break;
if (job.err_flag.load(.monotonic)) break;

did_work = true;

Expand Down
Loading