Merged
Conversation
Author
|
Aside - I'm also curious about where Vite is going with Rolldown. Once that's stable, Vite will stop using Rollup and Esbuild, and just use Rollup – maybe the configuration will be simpler then, it might be a good time to revisit Vite Library Mode. |
Author
|
Small additional fix here is adding |
padawannn
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins rollup v4 to resolutions. Previously Vite was using v4 (examples, local testing) but microbundle was using v2 (library builds). I tried switching over entirely to Vite, using Vite's Library Mode for the library builds (#60) but — as awesome as Vite is for building applications! — it seems really finicky for building libraries, I needed a lot of unexpected configuration just to get things working, and even then I couldn't get the sourcemaps or code coverage working.
It looks like Microbundle is already working on an update for Rollup, so I'd rather keep using that for now. We can remove the pinned resolution after the next Microbundle update, I'm tracking these issues: