Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5: follow-up hazard ratios could come from a different Cox model than the one the user fitted. Formula-based fits silently expanded to every eligible dataframe column.
This forwards the saved formula when
compute_followup_hazard_ratios()refits at each follow-up time.Example
On the bundled Rossi data, a model fitted with
formula="fin + age + race"returned seven terms from this method. At week 52, the reportedracehazard ratio was 1.368753 instead of the fitted model's 1.300095.Test
The regression test checks two contracts at maximum follow-up:
The existing no-formula path remains covered and passes.
Fixes #1702
Limits: this fixes model specification and numerical output. It does not identify an affected publication or establish a changed scientific conclusion.