Skip to content

bootloader: fix refind install crash when /boot is seperate #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptr1337 wants to merge 1 commit into
base: cachyos
Choose a base branch
from
Open

bootloader: fix refind install crash when /boot is seperate #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions src/modules/bootloader/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,16 +1035,23 @@ def install_refind(efi_directory):

check_target_env_call(["refind-install"])

with open(conf_path, "r") as refind_file:
filedata = [x.strip() for x in refind_file.readlines()]

with open(conf_path, 'w') as refind_file:
for line in filedata:
if line.startswith('"Boot with standard options"'):
line = f'"Boot with standard options" "{kernel_params}"'
elif line.startswith('"Boot to single-user mode"'):
line = f'"Boot to single-user mode" "{kernel_params}" single'
refind_file.write(line + "\n")
if os.path.exists(conf_path):
Copy link
Copy Markdown
Member

@ventureoo ventureoo Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we even want to read old config though?

with open(conf_path, "r") as refind_file:
filedata = [x.strip() for x in refind_file.readlines()]

with open(conf_path, 'w') as refind_file:
for line in filedata:
if line.startswith('"Boot with standard options"'):
line = f'"Boot with standard options" "{kernel_params}"'
elif line.startswith('"Boot to single-user mode"'):
line = f'"Boot to single-user mode" "{kernel_params}" single'
refind_file.write(line + "\n")
else:
# refind-install didn't create refind_linux.conf (e.g. separate /boot partition),
# so generate it manually
with open(conf_path, 'w') as refind_file:
refind_file.write(f'"Boot with standard options" "{kernel_params}"\n')
refind_file.write(f'"Boot to single-user mode" "{kernel_params}" single\n')

update_refind_config(efi_directory, installation_root_path)

Expand Down
Loading