-
Notifications
You must be signed in to change notification settings - Fork 3
Fix/update pipelines #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix/update pipelines #230
Changes from 4 commits
362feb0
6d18471
c79029b
4e957f2
9e69742
d902d26
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,9 @@ | |
| from embeddings.transformation.flair_transformation.split_sample_corpus_transformation import ( | ||
| SampleSplitsFlairCorpusTransformation, | ||
| ) | ||
| from embeddings.transformation.hf_transformation.class_encode_column_transformation import ( | ||
| ClassEncodeColumnTransformation, | ||
| ) | ||
| from embeddings.transformation.transformation import DummyTransformation | ||
| from embeddings.utils.flair_corpus_persister import FlairConllPersister, FlairPicklePersister | ||
|
|
||
|
|
@@ -62,6 +65,7 @@ class FlairPreprocessingPipeline( | |
| ignore_test_subset: bool = False | ||
| seed: int = 441 | ||
| load_dataset_kwargs: Optional[Dict[str, Any]] = None | ||
| encode_labels: bool = False | ||
|
|
||
| def __post_init__(self) -> None: | ||
| self.persister = self._get_persister() | ||
|
|
@@ -71,7 +75,7 @@ def __post_init__(self) -> None: | |
| super(FlairPreprocessingPipeline, self).__init__(dataset, data_loader, transformation) | ||
|
|
||
| @abc.abstractmethod | ||
| def _get_base_dataset_transformation(self) -> FLAIR_DATASET_TRANSFORMATIONS_TYPE: | ||
| def _get_to_flair_dataset_transformation(self) -> FLAIR_DATASET_TRANSFORMATIONS_TYPE: | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
|
|
@@ -89,17 +93,30 @@ def _get_dataloader(self, dataset: Dataset) -> FLAIR_DATALOADERS: | |
|
|
||
| def _get_dataset_transformation( | ||
| self, data_loader: FLAIR_DATALOADERS | ||
| ) -> FLAIR_DATASET_TRANSFORMATIONS_TYPE: | ||
| ) -> Optional[FLAIR_DATASET_TRANSFORMATIONS_TYPE]: | ||
| if isinstance(data_loader, (ConllFlairCorpusDataLoader, PickleFlairCorpusDataLoader)): | ||
| return DummyTransformation() | ||
| return None | ||
|
|
||
| return self._get_base_dataset_transformation() | ||
| return self._get_to_flair_dataset_transformation() | ||
|
|
||
| def _get_transformations( | ||
| self, data_loader: FLAIR_DATALOADERS | ||
| ) -> FLAIR_DATASET_TRANSFORMATIONS_TYPE: | ||
|
|
||
| transformation = self._get_dataset_transformation(data_loader) | ||
| transformation: FLAIR_DATASET_TRANSFORMATIONS_TYPE = DummyTransformation() | ||
| if self.encode_labels: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. consider early exit, without extra nested if? |
||
| if isinstance(data_loader, (ConllFlairCorpusDataLoader, PickleFlairCorpusDataLoader)): | ||
| raise ValueError( | ||
| "ClassEncodeColumnTransformation transformation is unavailable for Flair DataLoaders. " | ||
| "Set parameter `encode_labels` value to True" | ||
| ) | ||
| transformation = transformation.then( | ||
| ClassEncodeColumnTransformation(column=self.target_column_name) | ||
| ) | ||
|
|
||
| to_flair_dataset_transformation = self._get_dataset_transformation(data_loader) | ||
| if to_flair_dataset_transformation: | ||
| transformation = transformation.then(to_flair_dataset_transformation) | ||
|
ktagowski marked this conversation as resolved.
Outdated
|
||
|
|
||
| if self.sample_missing_splits: | ||
| transformation = transformation.then( | ||
|
|
@@ -126,7 +143,7 @@ class FlairTextClassificationPreprocessingPipeline(FlairPreprocessingPipeline): | |
| def _get_persister(self) -> FLAIR_PERSISTERS_TYPE: | ||
| return FlairPicklePersister(self.persist_path) | ||
|
|
||
| def _get_base_dataset_transformation(self) -> FLAIR_DATASET_TRANSFORMATIONS_TYPE: | ||
| def _get_to_flair_dataset_transformation(self) -> FLAIR_DATASET_TRANSFORMATIONS_TYPE: | ||
| assert isinstance(self.input_column_name, str) | ||
| return ClassificationCorpusTransformation( | ||
| input_column_name=self.input_column_name, | ||
|
|
@@ -138,7 +155,7 @@ def _get_base_dataset_transformation(self) -> FLAIR_DATASET_TRANSFORMATIONS_TYPE | |
| class FlairTextPairClassificationPreprocessingPipeline( | ||
| FlairTextClassificationPreprocessingPipeline | ||
| ): | ||
| def _get_base_dataset_transformation(self) -> FLAIR_DATASET_TRANSFORMATIONS_TYPE: | ||
| def _get_to_flair_dataset_transformation(self) -> FLAIR_DATASET_TRANSFORMATIONS_TYPE: | ||
| assert isinstance(self.input_column_name, (tuple, list)) | ||
| return PairClassificationCorpusTransformation( | ||
| input_columns_names_pair=self.input_column_name, | ||
|
|
@@ -151,7 +168,7 @@ class FlairSequenceLabelingPreprocessingPipeline(FlairPreprocessingPipeline): | |
| def _get_persister(self) -> FLAIR_PERSISTERS_TYPE: | ||
| return FlairConllPersister(self.persist_path) | ||
|
|
||
| def _get_base_dataset_transformation(self) -> FLAIR_DATASET_TRANSFORMATIONS_TYPE: | ||
| def _get_to_flair_dataset_transformation(self) -> FLAIR_DATASET_TRANSFORMATIONS_TYPE: | ||
| assert isinstance(self.input_column_name, str) | ||
| return ColumnCorpusTransformation( | ||
| input_column_name=self.input_column_name, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import datasets | ||
|
|
||
| from embeddings.transformation.transformation import Transformation | ||
|
|
||
|
|
||
| class ClassEncodeColumnTransformation(Transformation[datasets.DatasetDict, datasets.DatasetDict]): | ||
| def __init__( | ||
| self, | ||
| column: str, | ||
| ): | ||
| self.column = column | ||
|
|
||
| def transform(self, data: datasets.DatasetDict) -> datasets.DatasetDict: | ||
| return data.class_encode_column(column=self.column) |
Uh oh!
There was an error while loading. Please reload this page.