sirfunctions 2.1.7#437
Merged
Merged
Conversation
…with-the-pins-board-on-azure ❇️ Function to interact with the pins board on Azure
Updated to allow countries with commas in the name to pass as one country.
<<- will be a warning when devtools::check() runs. assign() is a way to circumvent that
when generating the positives timeliness data
some date collections are more than a year ahead of the date onset
…ith-commas-in-the-name 403 init dr cant find countries with commas in the name
Removed the pop data renaming code because it was not doing anything with the new names in pop dataset.
- correct region lookup to ensure WPRO for Indonesia - correctly get_ctry_abbrev function to address Paraguay
-add filter to the image to only show High Priority countries
various updates to correct violin plot outputs: - some cleanup of unnecessary code - change y_max for two violin plots to be max of indicator - correct a lab indicator to ensure all seq.capcity are considered
correct issue with return df
correction to added y_max to allow user to enter a number as a function argument
update to kpi template to add code for users to check violin ranges
update documentation with document()
additional changes to kpi template
change to what is an error in github actions check
changes to kpi template
KPI functions not working
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
========================================
- Coverage 2.01% 2.00% -0.02%
========================================
Files 37 38 +1
Lines 15002 15079 +77
========================================
Hits 302 302
- Misses 14700 14777 +77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
michellesloan-cdc
left a comment
michellesloan-cdc
left a comment
Collaborator
Author
There was a problem hiding this comment.
Ready for review
chadhunt2
approved these changes
Apr 16, 2026
chadhunt2
left a comment
chadhunt2
left a comment
Collaborator
There was a problem hiding this comment.
PR looks good. Took time to try to understand the codecov report. Looks like it's related to unit testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes PR #430
Closes PR #404