Skip to content

1008: Global settings layering and placement adjustments upon shortcut link#1708

Open
glstott wants to merge 2 commits into
CDCgov:devfrom
glstott:1008
Open

1008: Global settings layering and placement adjustments upon shortcut link#1708
glstott wants to merge 2 commits into
CDCgov:devfrom
glstott:1008

Conversation

@glstott

@glstott glstott commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

This addresses GH issue #1008. Fixes Global Settings dialog stacking and placement when opened from local view settings shortcuts.

Summary of revisions:

  • Adds a typed GlobalSettingsDialogRequest that can carry the active tab plus the source settings dialog rect.
  • Updates Global Settings opening logic to keep legacy string requests working while raising Global Settings above source dialogs with a higher baseZIndex.
  • Adds placement logic that tries right, left, below, then above the source dialog, clamps to viewport, and chooses the least-overlapping visible placement.
  • Wires dialog-origin shortcuts in 2D Network, Bubble, Map, and Phylogenetic views to pass click context into the Global Settings opener.
  • Adds a focused Cypress regression covering the 2D “Show Colors” flow, asserting both dialogs stay visible, Global Settings is topmost, has higher z-index, and does not overlap on a wide viewport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant