Skip to content

[IMPROVEMENT] Add test case for cascade-failure behavior in nicediff #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hell1213 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[IMPROVEMENT] Add test case for cascade-failure behavior in nicediff #1088

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67f1734
test: add cascade-failure test for nicediff comparison
Hell1213 Apr 2, 2026
cb873bd
Merge branch 'master' into add-cascade-failure-test
Hell1213 Apr 2, 2026
84c980c
Merge branch 'master' into add-cascade-failure-test
Hell1213 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tests/test_test/test_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,21 @@ def test_if_full_diff_download(self):
obtained_tr_count = obtained_diff.count("</tr>")

self.assertGreater(obtained_tr_count, limit_tr_count)

def test_cascade_failure_missing_entry(self):
"""Test cascade-failure when subtitle entries are missing."""
expected_sub = [
'1\n', '00:00:01,000 --> 00:00:02,000\n', 'First line\n',
'2\n', '00:00:03,000 --> 00:00:04,000\n', 'Second line\n'
]
obtained_sub = [
'1\n', '00:00:01,000 --> 00:00:02,000\n', 'First line\n',
'3\n', '00:00:05,000 --> 00:00:06,000\n', 'Third line\n'
]

diff_html = get_html_diff(expected_sub, obtained_sub)

self.assertIn('Third', diff_html)
self.assertIn('Second', diff_html)
self.assertIn('05', diff_html)
self.assertIn('03', diff_html)
Loading