Repository navigation
Do not take a chain's root CA for a self-signed signer - #597
Merged
doomedraven merged 1 commit intoSep 25, 2026
Merged
Conversation
A root CA signs itself, so every complete chain holds a self-signed certificate, and pe_cert_self_signed flagged it unless its name was in KNOWN_CA_TERMS. Now that digital_signers is filled again it fired on legitimately signed files whose root is missing from that list: an Indigo Rose binary signed through COMODO, rooted at UTN-USERFirst-Object. Only flag a self-signed certificate that issued none of the others in the chain, for both digital_signers and the guest's signtool chain. Over 31 reports from a production CAPEv2 this drops that one false positive and keeps the four real ones, single self-signed certificates under made-up company names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A root CA signs itself, so every complete certificate chain holds a self-signed certificate, and
pe_cert_self_signedflagged it unless its name was inKNOWN_CA_TERMS. Sincedigital_signersis filled again (and read fromtarget.fileafter #596), this fires on legitimately signed files whose root is missing from that list, e.g. an Indigo Rose binary signed through COMODO and rooted atUTN-USERFirst-Object.This only flags a self-signed certificate that issued none of the other certificates in the chain, i.e. the signer itself, for both
digital_signersand the guest's signtool chain (guest_signers).Testing: over 31 reports from a production CAPEv2, the false positive above goes away and the four real hits remain: single self-signed certificates under made-up company names.