Add Windows application icon (icon.ico)#961
Open
IcanBENCHurCAT wants to merge 1 commit into
Open
Conversation
- Add icon.ico (256x256 multi-size ICO) to C7/ directory - This fixes issue C7-Game#149: Windows file explorer now shows the OpenCiv3 app icon instead of the default Godot icon - Godot uses icon.ico for the Windows file explorer application icon - The existing icon.png continues to serve as the window/icon resource See: https://docs.godotengine.org/en/stable/tutorials/export/ changing_application_icon_for_windows.html
Contributor
|
Thanks @IcanBENCHurCAT ! @WildWeazel do you think that perhaps we should move this in the Assets repo? |
Member
|
I think the icon belongs here as it's an integral part of the application. I'd still rather someone draw a better icon though :D |
Author
Windows screenshots |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #149
What was changed
Added
C7/icon.ico- a multi-size Windows icon file (256x256, 128x128, 64x64, 48x48, 32x32, 16x16) generated from the existingC7/icon.png.Why
Per the Godot documentation, Windows applications need an
.icofile in the project folder to display the application icon in Windows File Explorer. Before this change, the application icon shown in Explorer was the default Godot placeholder icon, even though the window icon (in the title bar) was already correctly set.Technical details
C7/icon.png(128x128 RGBA PNG) was upscaled to 256x256 and converted to multi-resolution ICO format using Pillow (Python)..icofile is committed directly - no build step or external tool required.project.godotsettingconfig/icon="res://icon.png"continues to work for the window icon.icon.icoin the project root for Windows file explorer integration.Files changed
C7/icon.ico- new file (multi-size Windows ICO, 350 KB)