Skip to content

Fix LoadSystem Spec Expectations #109

Description

@corymosiman12

The test adjusting the schedules is currently failing. We are not positive where the 'expected' numbers are coming from:

it 'should parse and write building_151.xml and adjust schedules successfully' do
# -- Setup
file_name = 'building_151.xml'
std = CA_TITLE24
xml_path, output_path = create_xml_path_and_output_path(file_name, std, __FILE__, 'v2.2.0')
epw_path = nil
translator = translator_sizing_run_and_check(xml_path, output_path, epw_path, std)
model = translator.get_model
cut_off_value = 0.5
# read in the schedule
space_types = model.getSpaceTypes
expect(space_types.length).to be 4
space_types.each do |space_type|
default_schedule_set = space_type.defaultScheduleSet.get
puts "default_schedule_set: #{default_schedule_set.name} for space type: #{space_type.name}"
help_print_all_schedules("schedules-#{space_type.name}.csv", default_schedule_set)
expect(help_calculate_hours(default_schedule_set.numberofPeopleSchedule, cut_off_value).round(1)).to be 47.9
expect(help_calculate_hours(default_schedule_set.hoursofOperationSchedule, cut_off_value).round(1)). to be 40.0
expect(help_calculate_hours(default_schedule_set.peopleActivityLevelSchedule, cut_off_value).round(1)). to be 168.0
expect(help_calculate_hours(default_schedule_set.lightingSchedule, cut_off_value).round(1)). to be 67.0
expect(help_calculate_hours(default_schedule_set.electricEquipmentSchedule, cut_off_value).round(1)).to be 67.4
expect(help_calculate_hours(default_schedule_set.gasEquipmentSchedule, cut_off_value).round(1)).to be 0.0
expect(help_calculate_hours(default_schedule_set.hotWaterEquipmentSchedule, cut_off_value).round(1)).to be 0.0
expect(help_calculate_hours(default_schedule_set.infiltrationSchedule, cut_off_value).round(1)).to be 66.0
expect(help_calculate_hours(default_schedule_set.steamEquipmentSchedule, cut_off_value).round(1)).to be 0.0
expect(help_calculate_hours(default_schedule_set.otherEquipmentSchedule, cut_off_value).round(1)).to be 0.0
break
end
end

It uses the parametric schedule code:

# Infer the current hours of operation schedule for the building

We need to:

  • Document where the expected numbers are coming from
  • Fix the test to passing

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions