Skip to content

fix translations strings #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alessandro-Barbieri wants to merge 29 commits into
base: master
Choose a base branch
from
Open

fix translations strings #426

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
2d9acda
lowercase all the strings
Alessandro-Barbieri Feb 23, 2026
cc69ebb
Merge branch 'master' into lowercase
Alessandro-Barbieri Feb 23, 2026
8e69e2a
typo
Alessandro-Barbieri Feb 23, 2026
90ea691
wip
Alessandro-Barbieri Feb 23, 2026
eec325b
wip
Alessandro-Barbieri Feb 23, 2026
1ab3fee
wip
Alessandro-Barbieri Feb 23, 2026
511ade0
Merge branch 'BreakBB:master' into lowercase
Alessandro-Barbieri Feb 23, 2026
bd244f7
reset profile
Alessandro-Barbieri Feb 25, 2026
1a7e980
re-add deleted line
Alessandro-Barbieri Mar 2, 2026
930ae37
end sentences with a full stop
Alessandro-Barbieri Mar 2, 2026
5eb639a
Merge branch 'BreakBB:master' into lowercase
Alessandro-Barbieri Mar 4, 2026
f1fcf83
partial revert
Alessandro-Barbieri Mar 14, 2026
38fa667
partial revert
Alessandro-Barbieri Mar 14, 2026
01c1ccb
partial revert
Alessandro-Barbieri Mar 14, 2026
7e7967f
partial revert
Alessandro-Barbieri Mar 14, 2026
1d9381e
partial revert
Alessandro-Barbieri Mar 14, 2026
ccbd444
partial revert
Alessandro-Barbieri Mar 14, 2026
4471ebd
partial revert
Alessandro-Barbieri Mar 14, 2026
8f5cce9
partial revert
Alessandro-Barbieri Mar 14, 2026
b8116fd
more things
Alessandro-Barbieri Mar 14, 2026
cbfa1a1
leftovers
Alessandro-Barbieri Mar 14, 2026
962bd58
more leftovers
Alessandro-Barbieri Mar 14, 2026
ffee295
more fixes
Alessandro-Barbieri Mar 14, 2026
6e271a7
more
Alessandro-Barbieri Mar 14, 2026
e74923a
remove stray line
Alessandro-Barbieri Mar 14, 2026
669a374
Merge branch 'BreakBB:master' into lowercase
Alessandro-Barbieri Apr 29, 2026
a5e047d
Merge branch 'BreakBB:master' into lowercase
Alessandro-Barbieri Jun 11, 2026
d1a9e39
Merge branch 'master' into lowercase
Alessandro-Barbieri Aug 1, 2026
4d757eb
Update profile version from 26 to 27
Alessandro-Barbieri Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Modules/Config/Config.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ _GeneralTab = function()
generalHeader = {
type = "header",
order = 1,
name = function() return i18n("General Settings") end,
name = function() return i18n("General settings") end,
},
statsWindowClosedOnOpen = {
type = "toggle",
Expand All @@ -76,7 +76,7 @@ _GeneralTab = function()
addColorsToStatTexts = {
type = "toggle",
order = 2,
name = function() return i18n("Colorize Stats") end,
name = function() return i18n("Colorize stats") end,
desc = function() return i18n("Adds colors to the stats overview.") end,
width = "full",
get = function () return ExtendedCharacterStats.general.addColorsToStatTexts; end,
Expand Down Expand Up @@ -111,7 +111,7 @@ _GeneralTab = function()
showQualityColors = {
type = "toggle",
order = 3,
name = function() return i18n("Show Item Quality Colors") end,
name = function() return i18n("Show item quality colors") end,
desc = function() return i18n("Shows/Hides the colored frames around equipped items.") end,
width = "full",
get = function () return ExtendedCharacterStats.general.showQualityColors; end,
Expand All @@ -123,7 +123,7 @@ _GeneralTab = function()
qualityColorsIntensity = {
type = "range",
order = 4,
name = function() return i18n("Quality Colors' Intensity") end,
name = function() return i18n("Quality colors' intensity") end,
desc = function() return i18n("Changes the intensity of the colored frames' glow.") end,
width = "double",
min = 0.10,
Expand All @@ -138,7 +138,7 @@ _GeneralTab = function()
headerFontSize = {
type = "range",
order = 5,
name = function() return i18n("Header Font Size") end,
name = function() return i18n("Header font size") end,
desc = function() return i18n("Changes the font size of the headers (e.g. Melee)") end,
width = "double",
min = 8,
Expand All @@ -153,8 +153,8 @@ _GeneralTab = function()
statFontSize = {
type = "range",
order = 6,
name = function() return i18n("Stat Font Size") end,
desc = function() return i18n("Changes the font size of the stat lines (e.g. Crit)") end,
name = function() return i18n("Stat font size") end,
desc = function() return i18n("Changes the font size of the stat lines (e.g. Crit.)") end,
width = "double",
min = 8,
max = 18,
Expand All @@ -168,7 +168,7 @@ _GeneralTab = function()
windowWidth = {
type = "range",
order = 7,
name = function() return i18n("Window Width") end,
name = function() return i18n("Window width") end,
desc = function() return i18n("Changes the width of the stats window") end,
width = "double",
min = 12,
Expand Down Expand Up @@ -241,7 +241,7 @@ _StatsTab = function ()
statsHeader = {
type = "header",
order = 1,
name = function() return i18n("Stats Settings") end,
name = function() return i18n("Stats settings") end,
},
generalGroup = _Config:LoadGeneralSection(),
meleeGroup = _Config:LoadMeleeSection(),
Expand Down
18 changes: 9 additions & 9 deletions Modules/Config/DefenseSection.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function _Config:LoadDefenseSection()
showDefenseStats = {
type = "toggle",
order = 0,
name = function() return i18n("Show Defense Stats") end,
name = function() return i18n("Show defense stats") end,

@BreakBB BreakBB Mar 2, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think stat names should be lower case. So I'd prefer "Defense" over "defense" and "Mana" over "mana" and "Shadow Damage" over "Shadow damage".

The default UI is also using capitalized words like "Crit Chance".

I am okay with using "stats" and "values". For me "Hit Rating" is also a stat name, so I don't think it should be lower case.

@Alessandro-Barbieri Alessandro-Barbieri Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see many consistency issues right now:

  • majority of phrases that start with "Show" are in lowercase except in german
  • stats names (without a sentence attached) are capitalized only in english and german

@BreakBB BreakBB Mar 14, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do expect inconsistencies when comparing different languages. I personally can only check on correctness on English and German. And for both stat names should be capitalized.

If a translation does not follow the rules of the Blizzard UI or their basic grammatical rules that is a) something up to fix for a native speaker and b) not really a big issue.

Not sure what languages you can assess, but feel free to update the translations for these.

@Alessandro-Barbieri Alessandro-Barbieri Mar 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be consistent with blizzard globalstrings

ITEM_MOD_CRIT_SPELL_RATING = "Improves spell critical strike rating by %s.";
ITEM_MOD_CRIT_SPELL_RATING_SHORT = "Critical Strike (Spell)";
ITEM_MOD_CRIT_SPELL_RATING = "Mejora el índice de golpe crítico con hechizos en %s p.";
ITEM_MOD_CRIT_SPELL_RATING_SHORT = "Golpe crítico (hechizo)";
ITEM_MOD_CRIT_SPELL_RATING = "Augmente de %s le score de coup critique des sorts.";
ITEM_MOD_CRIT_SPELL_RATING_SHORT = "Score de critique (sorts)";
ITEM_MOD_CRIT_SPELL_RATING = "Erhöht die kritische Zaubertrefferwertung um %s.";
ITEM_MOD_CRIT_SPELL_RATING_SHORT = "Kritischer Trefferwert (Zauber)";
ITEM_MOD_CRIT_SPELL_RATING = "Критический удар (заклинания) +%s.";
ITEM_MOD_CRIT_SPELL_RATING_SHORT = "к критическому эффекту заклинаний";

I put sentences lowercase, the rest uppercase (English only)
German is all uppercase, the other languages lowercase
I also added full stops at the end of sentences and abbreviations

desc = function() return i18n("Shows/Hides all defense stats.") end,
width = 1.5,
get = function () return ExtendedCharacterStats.profile.defense.display; end,
Expand All @@ -45,7 +45,7 @@ function _Config:LoadDefenseSection()
meleeCritReduction = {
type = "toggle",
order = 1.81,
name = function() return i18n("Melee Crit Reduction") end,
name = function() return i18n("Melee crit. reduction") end,
desc = function() return i18n("Shows/Hides the reduction percentage of being critically hit by melee attacks.") end,
width = 1.5,
disabled = function() return (not ExtendedCharacterStats.profile.defense.display); end,
Expand All @@ -58,7 +58,7 @@ function _Config:LoadDefenseSection()
rangedCritReduction = {
type = "toggle",
order = 1.82,
name = function() return i18n("Ranged Crit Reduction") end,
name = function() return i18n("Ranged crit. reduction") end,
desc = function() return i18n("Shows/Hides the reduction percentage of being critically hit by ranged attacks.") end,
width = 1.5,
disabled = function() return (not ExtendedCharacterStats.profile.defense.display); end,
Expand All @@ -71,7 +71,7 @@ function _Config:LoadDefenseSection()
spellCritReduction = {
type = "toggle",
order = 1.83,
name = function() return i18n("Spell Crit Reduction") end,
name = function() return i18n("Spell crit. reduction") end,
desc = function() return i18n("Shows/Hides the reduction percentage of being critically hit by spells.") end,
width = 1.5,
disabled = function() return (not ExtendedCharacterStats.profile.defense.display); end,
Expand Down Expand Up @@ -110,7 +110,7 @@ function _Config:LoadDefenseSection()
defenseRating = {
type = "toggle",
order = 1.9,
name = function() return i18n("Defense Rating") end,
name = function() return i18n("Defense rating") end,
desc = function() return i18n("Shows/Hides the defense rating.") end,
width = 1.5,
hidden = function() return ECS.IsClassic end,
Expand All @@ -137,7 +137,7 @@ function _Config:LoadDefenseSection()
blockChance = {
type = "toggle",
order = 3,
name = function() return i18n("Block Chance") end,
name = function() return i18n("Block chance") end,
desc = function() return i18n("Shows/Hides the block chance.") end,
width = 1.5,
hidden = function() return not IsSpellKnown(107) end,
Expand All @@ -151,7 +151,7 @@ function _Config:LoadDefenseSection()
blockValue = {
type = "toggle",
order = 4,
name = function() return i18n("Block Value") end,
name = function() return i18n("Block value") end,
desc = function() return i18n("Shows/Hides the block value.") end,
width = 1.5,
hidden = function() return not DataUtils:CanBlock() end,
Expand All @@ -165,7 +165,7 @@ function _Config:LoadDefenseSection()
parry = {
type = "toggle",
order = 5,
name = function() return i18n("Parry Chance") end,
name = function() return i18n("Parry chance") end,
desc = function() return i18n("Shows/Hides the parry chance.") end,
width = 1.5,
hidden = function() return not DataUtils:CanParry() end,
Expand All @@ -179,7 +179,7 @@ function _Config:LoadDefenseSection()
dodge = {
type = "toggle",
order = 6,
name = function() return i18n("Dodge Chance") end,
name = function() return i18n("Dodge chance") end,
desc = function() return i18n("Shows/Hides the dodge chance.") end,
width = 1.5,
disabled = function() return (not ExtendedCharacterStats.profile.defense.display); end,
Expand Down
4 changes: 2 additions & 2 deletions Modules/Config/GeneralSection.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function _Config:LoadGeneralSection()
showGeneralStats = {
type = "toggle",
order = 0,
name = function() return i18n("Show General Stats") end,
name = function() return i18n("Show general stats") end,
desc = function() return i18n("Shows/Hides all general stats.") end,
width = 1.5,
get = function () return ExtendedCharacterStats.profile.general.display; end,
Expand All @@ -30,7 +30,7 @@ function _Config:LoadGeneralSection()
movementSpeed = {
type = "toggle",
order = 1,
name = function() return i18n("Show Movement Speed") end,
name = function() return i18n("Show movement speed") end,
desc = function() return i18n("Shows/Hides the movement speed value.") end,
width = 1.5,
disabled = function() return (not ExtendedCharacterStats.profile.general.display); end,
Expand Down
2 changes: 1 addition & 1 deletion Modules/Config/ManaSection.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function _Config:LoadManaSection()
showManaStats = {
type = "toggle",
order = 0,
name = function() return i18n("Show Mana Stats") end,
name = function() return i18n("Show mana stats") end,
desc = function() return i18n("Shows/Hides all mana stats.") end,
width = 1.5,
get = function () return ExtendedCharacterStats.profile.regen.display; end,
Expand Down
Loading
Loading