Skip to content

feat: update LSP to use new chumsky parser - #223

Merged
KyrylR merged 1 commit into
BlockstreamResearch:masterfrom
distributed-lab:lsp/chumsky-migration
Apr 2, 2026
Merged

feat: update LSP to use new chumsky parser#223
KyrylR merged 1 commit into
BlockstreamResearch:masterfrom
distributed-lab:lsp/chumsky-migration

Conversation

@gerau

@gerau gerau commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR updates LSP to use new features of chumsky parser. Also some functions was using Span struct, which was changed by parser migration, so it contains necessary changes for that too.

@gerau
gerau force-pushed the lsp/chumsky-migration branch 3 times, most recently from c0fc0af to fd05434 Compare March 23, 2026 12:26
@gerau
gerau marked this pull request as ready for review March 23, 2026 12:27
@gerau
gerau requested a review from delta1 as a code owner March 23, 2026 12:27
@gerau

gerau commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

cc @KyrylR

KyrylR
KyrylR reviewed Mar 25, 2026
View reviewed changes
Comment thread lsp/src/utils.rs
KyrylR
KyrylR reviewed Mar 25, 2026
View reviewed changes
Comment thread lsp/src/main.rs Outdated
@gerau
gerau force-pushed the lsp/chumsky-migration branch from fd05434 to 026318b Compare March 26, 2026 10:27
@gerau

gerau commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

Fixed the offset issue and added try_from where needed.
cc @KyrylR

@gerau
gerau force-pushed the lsp/chumsky-migration branch from 026318b to 0113991 Compare March 26, 2026 12:28
@gerau gerau mentioned this pull request Mar 26, 2026
Closed
@gerau
gerau force-pushed the lsp/chumsky-migration branch 2 times, most recently from e1d255b to 3b8d035 Compare March 30, 2026 13:39
@KyrylR
KyrylR force-pushed the lsp/chumsky-migration branch 2 times, most recently from 2711400 to 22c2b96 Compare April 2, 2026 10:10
@KyrylR
KyrylR force-pushed the lsp/chumsky-migration branch from 22c2b96 to 682b10e Compare April 2, 2026 10:14
KyrylR
KyrylR approved these changes Apr 2, 2026
View reviewed changes

@KyrylR KyrylR left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 682b10e; code review

Note: discussed it with @gerau and decided to squash the commit to address utf16 parsing issue in the position_to_offset

@KyrylR
KyrylR merged commit 4203177 into BlockstreamResearch:master Apr 2, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KyrylR KyrylR KyrylR approved these changes
@delta1 delta1 Awaiting requested review from delta1 delta1 is a code owner
+1 more reviewer
@Ari4ka Ari4ka Ari4ka approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gerau @KyrylR @Ari4ka