proto: Document that CheckLightningAvailability is monotonic - #743
Merged
Conversation
The scheduler now short-circuits the availability check against its own `nodes` table: a node that has been registered is reported as available, and stays available regardless of its status or of the LSP's current capacity. Only unregistered nodes are relayed to the LSP, where the answer remains advisory. Spell that out in the proto and in the gl-client and gl-sdk wrappers so applications can rely on an account not disappearing once they have acted on the answer. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016awJpKKEr47696UvT7n1Lc
A node registered with the mock scheduler now answers CheckLightningAvailability with `true`, matching the real scheduler. The `lightning_available` flag keeps deciding for unregistered nodes, so tests exercising the pre-registration path are unaffected. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016awJpKKEr47696UvT7n1Lc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduler now short-circuits
Scheduler.CheckLightningAvailabilityagainst its ownnodestable: a node that has been registered is reported as available, and stays available regardless of its status or of the LSP's current capacity. Only unregistered nodes are relayed to the LSP, where the answer remains advisory.gl-clientandgl-sdkwrappers and changelogs, so applications can rely on an account not disappearing once they have acted on the answer.gl-testingmock scheduler: a registered node answerstrue; thelightning_availableflag keeps deciding for unregistered nodes.The regenerated Python stubs differ only in docstrings.
Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_016awJpKKEr47696UvT7n1Lc