-
Notifications
You must be signed in to change notification settings - Fork 48
Added splicing plumbing #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 6 commits
326818b
19fcc43
5a7d1a0
8a285b8
da55526
2b9b71d
4b3fa1b
02095aa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,18 @@ | ||
| mod canonical; | ||
| #[allow(dead_code)] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [ISSUE] Is this dead-code or should it be a
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was genuine dead-code, but it's removed now |
||
| mod splice; | ||
|
|
||
| pub use splice::{ | ||
| candidate_funding_facts_from_psbt, psbt_shape_from_base64, wallet_inputs_from_psbt, FeePolicy, | ||
| FundPsbtResponseFacts, FundingOutpoint, LocalSpliceIntent, NormalizedRpcAuth, OldSpliceState, | ||
| SignPsbtIntentFacts, SignPsbtResponseFacts, SpliceSignedResponseFacts, | ||
| SpliceUpdateResponseFacts, WalletInputReservation, WalletInputSource, | ||
| }; | ||
| pub(crate) use splice::{ | ||
| psbt_shape_from_psbt, transaction_shape, SpliceOrigin, SplicePhase, SpliceSessionV1, | ||
| }; | ||
| #[cfg(test)] | ||
| pub(crate) use splice::{CandidateFundingFacts, WalletInput}; | ||
|
|
||
| use anyhow::anyhow; | ||
| use lightning_signer::bitcoin::secp256k1::PublicKey; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ISSUE] Shouldn't we rather remove the
decodepaymethod, or are we keeping it for backwards compatibility?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was meant for backward compatibility. It was removed in CLN and the updated python bindings, but I wasn't sure if anyone depends on it. But if you are ok with removing it, let's do it