Fix expired qBittorrent sessions without a ROMarr restart - #14
Open
BlizzHacker wants to merge 1 commit into
Open
Fix expired qBittorrent sessions without a ROMarr restart#14BlizzHacker wants to merge 1 commit into
BlizzHacker wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
ROMarr keeps its qBittorrent client for the lifetime of the process, but qBittorrent sessions expire. Once that happened, health checks, completed-download polling, and new grabs stayed broken until ROMarr was restarted even though the stored credentials were valid.
This was reproduced against the live qBittorrent 5.x instance: a ROMarr restart restored the connection immediately. The deployed patch now keeps the session self-healing.
Verification
python -m pytest tests/test_qbittorrent_login.py tests/test_qbittorrent_excluded_files.py -q— 22 passedbash.exe, not Python/application failuresconfigured=true, ok=true; RomMok=true, readable=true; GG Requestzok=true