Allow 401 status without requiring HTTP authentication#120
Merged
Conversation
Collaborator
|
Approved! I really liked the idea of having the |
Baraujo25
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a custom protocol handler to improve how HTTP 401 responses are handled in the BlazeMeter Jetty-based HTTP client. The main goal is to allow 401 responses without a
WWW-Authenticateheader (common with app-level authentication like JWT or API keys) to be returned as normal responses, matching the behavior of JMeter's HttpClient4. Previously, Jetty would treat these as protocol violations and fail the exchange. The change is validated with new unit tests.Authentication protocol handler improvements:
CustomWwwAuthenticationProtocolHandleras a replacement for Jetty's default handler, allowing 401 responses withoutWWW-Authenticateto be returned to the application instead of failing the request.HTTP2JettyClientto install the custom handler on all internalHttpClientinstances after startup. [1] [2] [3]Testing and test infrastructure:
WWW-Authenticateheader is handled as a normal 401 (not a protocol error), both with and without an authentication manager configured. [1] [2]ServerBuilderto support a test path (SERVER_PATH_401_NO_WWW_AUTHENTICATE) that returns a 401 without the header, and updated the test server logic accordingly. [1] [2]