[#1644] Fix incorrect projection extraction for subqueries (use join …#2108
Open
kamilkrzywanski wants to merge 1 commit intoBlazebit:mainfrom
Open
[#1644] Fix incorrect projection extraction for subqueries (use join …#2108kamilkrzywanski wants to merge 1 commit intoBlazebit:mainfrom
kamilkrzywanski wants to merge 1 commit intoBlazebit:mainfrom
Conversation
…se join target when projection is null) (default projection is root entity from first join)
| } | ||
|
|
||
| return firstJoin.getType() == com.querydsl.core.JoinType.DEFAULT | ||
| ? Projections.constructor(firstJoin.getTarget().getType()) |
Collaborator
There was a problem hiding this comment.
Is this a convenience (desugar) or query language feature? The PR is suggested as a fix but what states that subqueries without a projection were ever allowed in JPQL/JPQL Next?
Doing this kind of expression manipulation makes a few assumptions that may not always be true:
- The entity is a class
- The entity name is the classname
- The entity name is the alias for the select expression
Please add a test case to https://github.com/Blazebit/blaze-persistence/blob/main/integration/querydsl/testsuite/src/test/java/com/blazebit/persistence/querydsl/BasicQueryTest.java so we can have a look that the desired query behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix incorrect projection extraction for subqueries (use join target when projection is null) (default projection is root entity from first join)
Related Issue
#1644
I didn't write tests because there is no place where I could test Querydsl + views