[#1414] Fix Quarkus extension metadata take 2#1416
Merged
Conversation
gsmet
commented
Jan 4, 2022
Comment on lines
+32
to
+33
| group-id: "${project.groupId}" | ||
| artifact-id: "${project.artifactId}" |
Contributor
Author
There was a problem hiding this comment.
These two are for some old versions of Quarkus before we moved to artifact.
Just did that: Error page on first load of Dev UI is gone and the tile is there. 👍 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1415 is the way to go for the future but Blaze Persistence still supports JDK 8 for now, which makes it a bit impractical.
So for now, we just update the metadata to a format that should work with latest Quarkus.
It should be tested by going to the Dev UI of a 2.6.1.Final project and make sure the BP tile is there.