Skip to content

Develop utility getters for ODBC APIs #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alinaliBQ merged 7 commits into from
Nov 7, 2025
Merged

Develop utility getters for ODBC APIs #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
486f56c
Develop getter for tests
alinaliBQ Oct 28, 2025
66c0e7d
Add SQLGetInfo getters
alinaliBQ Nov 5, 2025
a2152c4
Add comments
alinaliBQ Nov 6, 2025
a33b2aa
Swap EQ statements to have `value` as second input
alinaliBQ Nov 6, 2025
77381b5
Add getters for SQLColAttribute
alinaliBQ Nov 6, 2025
26325a0
Use PascalCase for function names
alinaliBQ Nov 7, 2025
83a4c17
Fix rest of PascalCase functions
alinaliBQ Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions cpp/src/arrow/flight/sql/odbc/odbc_impl/odbc_statement.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,14 @@ void ODBCStatement::GetStmtAttr(SQLINTEGER statement_attribute, SQLPOINTER outpu
return;
case SQL_ATTR_PARAM_BIND_TYPE:
current_apd_->GetHeaderField(SQL_DESC_BIND_TYPE, output, buffer_size, str_len_ptr);
if (output) {
// Convert SQLINTEGER output to SQLULEN, since SQL_DESC_BIND_TYPE is SQLINTEGER
// and SQL_ATTR_PARAM_BIND_TYPE is SQLULEN
SQLINTEGER* output_int_ptr = reinterpret_cast<SQLINTEGER*>(output);
SQLINTEGER output_int = *output_int_ptr;
SQLULEN* typed_output = reinterpret_cast<SQLULEN*>(output);
*typed_output = static_cast<SQLULEN>(output_int);
}
return;
case SQL_ATTR_PARAM_OPERATION_PTR:
current_apd_->GetHeaderField(SQL_DESC_ARRAY_STATUS_PTR, output, buffer_size,
Expand All @@ -422,6 +430,14 @@ void ODBCStatement::GetStmtAttr(SQLINTEGER statement_attribute, SQLPOINTER outpu
return;
case SQL_ATTR_ROW_BIND_TYPE:
current_ard_->GetHeaderField(SQL_DESC_BIND_TYPE, output, buffer_size, str_len_ptr);
if (output) {
// Convert SQLINTEGER output to SQLULEN, since SQL_DESC_BIND_TYPE is SQLINTEGER
// and SQL_ATTR_ROW_BIND_TYPE is SQLULEN
SQLINTEGER* output_int_ptr = reinterpret_cast<SQLINTEGER*>(output);
SQLINTEGER output_int = *output_int_ptr;
SQLULEN* typed_output = reinterpret_cast<SQLULEN*>(output);
*typed_output = static_cast<SQLULEN>(output_int);
}
return;
case SQL_ATTR_ROW_OPERATION_PTR:
current_ard_->GetHeaderField(SQL_DESC_ARRAY_STATUS_PTR, output, buffer_size,
Expand Down
Loading
Loading