Explain the lava mechanic behind each generator type, and sync the locales - #175
Merged
Merged
Conversation
The generator type controls which of the vanilla lava mechanics activates a tier, but the Generator Type button in the edit panel only said that it "defines which generator type will be applied". The hint about the mechanic behind each type was only visible after opening the type picker, so admins could easily miss that a STONE tier fires on any water a player can pour lava onto, oceans included. The button description now lists the mechanic for each type. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SDLdE5LSXRwc6NQhYvzyiv
This was referenced Aug 11, 2026
Merged
Closed
Every translated locale was 28 keys behind en-US: the admin reset command, the custom block conversation prompts, the accept_generator, activate_on_unlock, add_custom_block and required_generators buttons, the phase / block-count / required-generator requirement lines, the select generator title and the generator-data-reset message. Those keys fall back to the English text (or to the raw reference) in game. Translate and add all of them, and give the Generator Type button the same per-type explanation that en-US just gained, reusing the generator type names each file already uses in its type picker. Two placeholder lists were also stale, so features could not render at all in those languages: the generator lore was missing [height-range] and the requirements list was missing [phase], [block-count] and [required-generators]. Some files had the placeholder tokens themselves translated (for example [biomas], [缺失权限], [missing-permission]), which never matches what the code substitutes. Both lists are now the canonical tokens everywhere. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SDLdE5LSXRwc6NQhYvzyiv
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Follow-up to #173 / #174.
Generator Type button
The generator type is what decides which of the vanilla lava mechanics activates a tier, and it is the setting an admin needs when players start pouring lava onto open water. It is already in the Admin GUI, but the Generator Type button in the generator edit panel only said:
The useful part — that
COBBLESTONEmeans a lava stream meeting water,STONEmeans lava flowing down onto water, andBASALTmeans lava on soul soil next to blue ice — was only visible after clicking through to the type picker. As a result it is easy to read "Stone" as "produces stone" and never realise aSTONEtier fires on any water a player can reach, oceans included.The button description now lists the mechanic behind each type, so it is visible before opening the picker.
Locale sync
While adding that to the other languages it turned out every translated file was 28 keys behind
en-US, some of them for several releases: the adminresetcommand, the custom block conversation prompts, theaccept_generator,activate_on_unlock,add_custom_blockandrequired_generatorsbuttons, the phase / block-count / required-generator requirement lines, the select generator title and thegenerator-data-resetmessage. All 23 files now have them, translated, and each one gets the new type explanation using the type names it already uses in its own picker.Two placeholder lists were stale as well, which silently disabled features per language rather than just showing English:
[height-range], so height ranges never appeared;[phase],[block-count]and[required-generators], so those requirements were never shown;[biomas],[缺失权限],[missing-permission]), which never matches what the code substitutes.Both lists are now the canonical tokens in every file.
All 24 locale files parse, every non-English file is key-for-key in sync with
en-US, and the test suite passes (165 tests).A docs PR covering the same ground (type table, and the two ways to keep
STONEtiers off the ocean: do not hand them out, or give them a height range that excludes sea level) is open at docs#91.🤖 Generated with Claude Code
https://claude.ai/code/session_01SDLdE5LSXRwc6NQhYvzyiv