Skip to content

{Packaging} Update Homebrew template to use python3.10 executable#23788

Merged
jiasli merged 1 commit into
Azure:devfrom
chenrui333:patch-1
Sep 16, 2022
Merged

{Packaging} Update Homebrew template to use python3.10 executable#23788
jiasli merged 1 commit into
Azure:devfrom
chenrui333:patch-1

Conversation

@chenrui333
Copy link
Copy Markdown
Contributor

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.


update brew PR template, relates to Homebrew/homebrew-core#109727

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 6, 2022
@ghost
Copy link
Copy Markdown

ghost commented Sep 6, 2022

Thank you for your contribution chenrui333! We will review the pull request and get back to you soon.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Sep 6, 2022

homebrew

@carlocab
Copy link
Copy Markdown

carlocab commented Sep 6, 2022

For context here:

We recently changed the way we package Python formulae. The latest version will have a python3 executable added to the user's PATH, while earlier versions will only have ones with both the major and minor version. For example, brew install python@3.9 adds only python3.9 to your PATH, and no python3 will be in its bin directory. See Homebrew/homebrew-core#107517.

Hence, it makes sense to fully qualify python3 as python3.10 to make sure the reference is not broken when Python 3.11 is packaged in Homebrew.

@bebound bebound changed the base branch from master to dev September 7, 2022 07:02
@bebound bebound changed the title brew: update template {Packaging} Update Homebrew template Sep 7, 2022
@bebound
Copy link
Copy Markdown
Contributor

bebound commented Sep 8, 2022

@carlocab Correct me if I'm wrong. When 3.11 is not released, this PR makes no difference. After 3.11 is out, it will prevent linking python3 in user PATH?

@carlocab
Copy link
Copy Markdown

carlocab commented Sep 8, 2022

When 3.11 is released, python@3.10 will not have a python3 in its bin directory. It will only have python3.10, so we cannot rely on calling python3.10 as python3.

@bebound
Copy link
Copy Markdown
Contributor

bebound commented Sep 9, 2022

@chenrui333 Could you please sync this PR with dev branch? Thank you.

@carlocab
Copy link
Copy Markdown

ping @chenrui333

@jiasli jiasli changed the title {Packaging} Update Homebrew template {Packaging} Update Homebrew template to use python3.10 executable Sep 16, 2022
@jiasli jiasli merged commit 9113fc1 into Azure:dev Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants