-
Notifications
You must be signed in to change notification settings - Fork 612
refactor(wsdb): migrate aztec-wsdb to ipc-codegen + ipc-runtime #23611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 14 additions & 2 deletions
16
barretenberg/cpp/src/barretenberg/serialize/msgpack_impl/concepts.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,30 @@ | ||
| #pragma once | ||
|
|
||
| #ifndef IPC_CODEGEN_MSGPACK_CONCEPTS_DEFINED | ||
| #define IPC_CODEGEN_MSGPACK_CONCEPTS_DEFINED | ||
|
|
||
| struct DoNothing { | ||
| void operator()(auto...) {} | ||
| }; | ||
|
|
||
| namespace msgpack_concepts { | ||
|
|
||
| template <typename T> | ||
| concept HasMsgPack = requires(T t, DoNothing nop) { t.msgpack(nop); }; | ||
|
|
||
| template <typename T, typename... Args> | ||
| concept MsgpackConstructible = requires(T object, Args... args) { T{ args... }; }; | ||
|
|
||
| } // namespace msgpack_concepts | ||
|
|
||
| #endif | ||
|
|
||
| namespace msgpack_concepts { | ||
|
|
||
| template <typename T> | ||
| concept HasMsgPackSchema = requires(const T t, DoNothing nop) { t.msgpack_schema(nop); }; | ||
|
|
||
| template <typename T> | ||
| concept HasMsgPackPack = requires(T t, DoNothing nop) { t.msgpack_pack(nop); }; | ||
| template <typename T, typename... Args> | ||
| concept MsgpackConstructible = requires(T object, Args... args) { T{ args... }; }; | ||
|
|
||
| } // namespace msgpack_concepts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # VM2 adapter for native AVM simulation against aztec-wsdb. | ||
| if(TARGET vm2_sim AND TARGET wsdb_ipc_client) | ||
| add_library( | ||
| wsdb_ipc_merkle_db | ||
| STATIC | ||
| wsdb_ipc_merkle_db.cpp | ||
| ) | ||
| target_link_libraries( | ||
| wsdb_ipc_merkle_db | ||
| PUBLIC | ||
| barretenberg | ||
| vm2_sim | ||
| wsdb_ipc_client | ||
| ) | ||
| set_target_properties(wsdb_ipc_merkle_db PROPERTIES POSITION_INDEPENDENT_CODE ON) | ||
| endif() |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: pre-existing typo