Repository navigation
Close the WASD menu when a new round starts - #19
Closed
xiaoyueyoqwq wants to merge 1 commit into
Closed
xiaoyueyoqwq wants to merge 1 commit into
xiaoyueyoqwq wants to merge 1 commit into
Conversation
An open overlay kept painting through team intro and the freeze-end prompt. Death already closes the menu; round_prestart covers the round boundary.
Owner
|
Thanks for splitting it out, this one is clean. The code is fine, my only concern is behavior, the end of a round is when most players open the menu, and with this they all get it closed at round start and have to reopen it in freeze time, to fix something that is cosmetic. I will take it as an option instead: your commit goes in with your authorship and I add Menu.CloseOnRoundStart on top, off by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If the WASD menu is still open when a round ends, its center HTML keeps painting through the team intro and overlaps the freeze-end prompt.
Death already closes the menu. Round restart does not.
Change
Close every open menu on
round_prestart. That is the sameClosepath death already uses: unfreeze, clear the overlay.No freeze, input, key, overlay, possession, or version changes.
Validation
dotnet build -c Release: 0 warnings, 0 errors