RTC: Send bell notification to plan owner when non-admin is blocked by collaborator limit#48001
Open
RTC: Send bell notification to plan owner when non-admin is blocked by collaborator limit#48001
Conversation
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCannot generate coverage summary while tests are failing. 🤐 Please fix the tests, or re-run the Code coverage job if it was something being flaky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DOTCOM-16367
Proposed changes
lib/directory tojetpack-mu-wpcomwith generic helper functions that work on both Simple and Atomic/WoW sites:wpcom_get_site_owner_id()— resolves the site/plan owner user ID across environmentswpcom_is_site_owner()— checks if the current user is the site ownerwpcom_send_bell_notification()— sends a WordPress.com bell notification (no-ops gracefully when unavailable)AGENTS.mdto the lib directory as agent-first documentation for AI agents to discover available operationsis_plan_owner()andget_plan_owner_id()to the new lib functionsjetpack_rtc_enable_limit_noticesfilter is enabledOther information
The
lib/directory is designed as an agent-first API surface — theAGENTS.mdfile serves as the primary discovery mechanism for AI agents working in the codebase. The functions use thewpcom_prefix consistent with existing conventions and are loaded early vialib/load.php.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
jetpack_rtc_enable_limit_noticesfilter returningtruejetpack_rtc_enable_limit_noticesisfalse(default)