Social: Individual scrolling and update social media preview mockups to match current platform by ederrengifo · Pull Request #47985 · Automattic/jetpack

ederrengifo · 2026-04-08T00:20:28Z

Fixes SOCIAL-432 SOCIAL-433

Proposed changes

Scrolling adjusment

Make scrolling working independently per each area (editor and preview content)
Change only work for desktop. For mobile, the content scrolling still work as before.

Adjustments in preview mockups

Adjusted Facebook mockup

Minor UI adjustments
Adjust logic to switch format for when image is too small, based on facebook guidelines
Adjusted max-width for card

Adjusted Twitter/X mockup

Minor UI adjustments
Adjusted preview image with title as overlay
Applied max-height to attachment

Adjusted LinkedIn

Minor UI adjustments
Adjusted preview card which now shows the image in a smaller size

Adjusted Instagram

Minor UI adjustments
Adjusted format for attachment based on platform limitations

Adjusted Tumblr

Minor UI adjustments
Updated link preview card with current format including title overlapping the image
Removed post content for when customize text exists (that's how it's displayed in Tumblr)
Adjusted format for attachment based on platform limitations
Adjusted max-width for card

Adjusted Mastodon

Minor UI adjustments
Updated link preview card
Try to recreate the inclusion of author as part of the preview card
Added max-height to attachment
Adjusted max-width for card

Adjusted Bluesky

Minor UI adjustments
Adjusted preview card UI
Added max-height to attachment
Adjusted max-width for card

Adjusted Threads

Minor UI adjustments
Adjusted preview card UI and width
Added max-height to attachment
Adjusted max-width for card

Other information

None

Related product discussion/links

p1HpG7-xW0

Does this pull request change what data or activity we track or use?

No

Testing instructions

Use the docs for useful testing snippets.

For the scrolling:

Upgrade account to see more elements in the modal
Make your screen smaller
See scroll working in the editor and the preview content

For the mockups:

Connected with each one of the listed platforms above
Compare the mockups with the platforms implementation (try to test link preview and attachment)

github-actions · 2026-04-08T00:21:40Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Super Cache plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2026-04-08T20:07:06Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the experiment/social-ui-fixes branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack experiment/social-ui-fixes

bin/jetpack-downloader test jetpack-mu-wpcom-plugin experiment/social-ui-fixes

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

jp-launch-control · 2026-04-08T20:23:41Z

Code Coverage Summary

Coverage changed in 15 files. Only the first 5 are listed here.

File	Coverage	Δ%	Δ Uncovered
projects/js-packages/social-previews/src/instagram-preview/post-preview.tsx	12/17 (70.59%)	70.59%	2 ❤️‍🩹
projects/js-packages/social-previews/src/facebook-preview/link-preview.tsx	3/3 (100.00%)	0.00%	0 💚
projects/js-packages/social-previews/src/twitter-preview/card.tsx	2/2 (100.00%)	0.00%	0 💚
projects/js-packages/social-previews/src/instagram-preview/icons/bookmark.tsx	2/2 (100.00%)	50.00%	-1 💚
projects/js-packages/social-previews/src/instagram-preview/icons/comment.tsx	2/2 (100.00%)	50.00%	-1 💚

2 files are newly checked for coverage.

File	Coverage
projects/js-packages/social-previews/src/instagram-preview/icons/repost.tsx	2/2 (100.00%) 💚
projects/js-packages/social-previews/src/linkedin-preview/post/actions/index.tsx	3/3 (100.00%) 💚

Full summary · PHP report · JS report

… UIs

gmjuhasz

Hi! Thanks for the braveness and jumping into this, I went through the code, this needs some refining on the code organization level. On a general note there are some things to be fixed, otherwise I also left specific things below as comments.

This PR got too big and should be separated into smaller PRs that are more focused on a specific fix/change.
There are some anti-patterns in the code like !important in scss files, which can cause races, we should use stricter selectors or modify those props in the parent if needed.
Every preview component had max-width: clamp(200px, 100%, Xpx) replaced with width: 100%; max-width: Xpx. The clamp() provided a minimum width of 200px, preventing the previews from collapsing too small. The new approach has no minimum width constraint. This could cause layout issues in narrow containers.
There are dead CSS selectors like
- .facebook-preview__description styles remain in style.scss but the element was removed from the component
- .facebook-preview__info remain but the element was removed
- Portrait/landscape mode classes removed from components but some related CSS may still exist
There are some hardcoded values without explanation more max-heights and other CSS props, probably we should generalize them as much as possible
projects/plugins/jetpack/_inc/client/traffic/seo.jsx still passes description and imageMode to FacebookLinkPreview, but the component no longer uses either prop. The description was displayed to users in the SEO preview — this is a silent feature regression.

projects/js-packages/number-formatters/.duel-cache/dual.708b8660.tsbuildinfo

projects/js-packages/number-formatters/.duel-cache/primary.708b8660.tsbuildinfo

gmjuhasz · 2026-04-09T11:20:03Z

projects/js-packages/charts/src/charts/leaderboard-chart/leaderboard-chart.tsx

 								return (
 									<Fragment key={ entry.id }>
-										<Stack direction="column" gap={ labelSpacing }>
+										<Stack direction="column" gap={ labelSpacing as number }>


This seems like a bandaid that hides a type issue that probably came up? It's in leaderboard-chart package which should be unrelated to the changes

yeah, this was causing a failure in the checks and Claude suggested to fix it quickly here. Is there any other way to just ignore it?

gmjuhasz · 2026-04-09T11:24:14Z

projects/js-packages/social-previews/src/linkedin-preview/post-preview.tsx

-									__( '1h', 'social-previews' )
-								}
-							</span>
+							<span>1h</span>


This change removes the translation and replaces it with a generic string

gmjuhasz · 2026-04-09T11:25:33Z

projects/js-packages/social-previews/src/linkedin-preview/post-preview.tsx

 					<div className="linkedin-preview__header--profile">
 						<div className="linkedin-preview__header--profile-info">
-							<div className="linkedin-preview__header--profile-name">
-								{ name || __( 'Account Name', 'social-previews' ) }


The name prop fallback __( 'Account Name', 'social-previews' ) was removed. Now if name is undefined/empty, nothing renders. The • separator and 1st indicator were also removed — are these intentional design changes?

Restoring both changes, the first one shouldn't have happened, and the second one initially thought as a way to simplify the mockup but in a second thought, would be better if matches better the output.

gmjuhasz · 2026-04-09T11:26:24Z

projects/js-packages/social-previews/src/facebook-preview/link-preview.tsx

-							<div
-								className={ `facebook-preview__description ${
-									compactDescription ? 'is-compact' : ''
-								}` }
-							>
-								{ description && facebookDescription( description ) }
-								{ isArticle &&
-									! description &&
-									// translators: Default description for a Facebook post
-									__( 'Visit the post for more.', 'social-previews' ) }
-							</div>
-							<div className="facebook-preview__info">
-								<FacebookPostIcon name="info" />
-							</div>


This removes the full Facebook description block, is that intentional?

Yes, facebook doesn't seem to show the description anymore as part of the link preview

gmjuhasz · 2026-04-09T11:27:28Z

projects/js-packages/social-previews/src/twitter-preview/card.tsx

This file got messed up quite a bit, I see description was removed here as well, the helper and cardType props also got removed, probably by accident?

Same as facebook, many link previews are not showing descriptions anymore. However, I understand the regression in terms of SEO so I'm fixing that aspect.

gmjuhasz · 2026-04-09T11:30:51Z

projects/js-packages/social-previews/src/instagram-preview/post-preview.tsx

+		const img = e.currentTarget;
+		const natural = img.naturalWidth / img.naturalHeight;
+		// Clamp between 4:5 (portrait) and 1.91:1 (landscape)
+		const clamped = Math.max( MIN_RATIO, Math.min( MAX_RATIO, natural ) );
+		setAspectRatio( clamped );
+	}, [] );


The aspect ratio is derived from the image and won't change — this could cause a visual flash/reflow when the image loads and the container resizes from 1:1 to the clamped ratio. I think we should be using CSS aspect-ratio with object-fit instead

As far as I understand, Instagram doesn't allow that flexibility to accomodate to the image's aspect ratio and forces the images to be shown within a specific one Source. I'm addressing this as a something to avoid the visual flash but still comply with the way the image will be shown based on Instagram rules. Does that make sense? Because the same happen also in other cases where the image has to be shown in specific ratios.

ederrengifo · 2026-04-09T15:05:04Z

Thank you for the review @gmjuhasz ! I will try to fix the issues first and then split it into smaller PRs. Do you suggest a PR for each mockup case? My first thinking was two PRs for the scrolling and the mockups but I also notice the changes in the mockups are not small.

…an dead CSS, restore min-width

ederrengifo · 2026-04-09T16:24:26Z

I addressed the feedback and here is a quick summary of the latest updates:

Bug fixes:

Restored translated __( '1h' ) time string in LinkedIn header
Restored Account Name fallback for empty LinkedIn name prop
Restored • 1st connection degree indicator in LinkedIn header
Fixed SEO regression: FacebookLinkPreview accepts description prop again (for seo.jsx consumer) but does not render it in the mockup, matching current Facebook UI

Code quality:

Removed all !important declarations — replaced with more specific selectors (e.g. .facebook-preview__post
.facebook-preview__url, .twitter-preview__card.twitter-preview__card)
Removed dead CSS: facebook-preview__info, facebook-preview__description.is-compact, is-portrait on body/image, is-empty image styles
Added min-width: 200px to all preview wrappers/sections to prevent collapse in narrow containers (restoring the clamp() minimum)
Added comments documenting platform-specific max-height values (510px Twitter, 430px Threads, 566px Mastodon, 516px Bluesky, 850px Facebook)
Removed build cache files from number-formatters

Instagram aspect ratio:

Replaced JS-only approach with hidden-until-loaded pattern (uses visibility: hidden during detection to prevent reflow flash, same pattern as Facebook's useImage hook)

Tumblr attachment: (Not part of the feedback but found the issue as I was testing)

Removed forced 4:3 aspect ratio — images now display at natural ratio, matching Tumblr's platform behavior

Twitter card border:

Replaced border: none !important with doubled class selector for higher specificity

ederrengifo self-assigned this Apr 8, 2026

ederrengifo added [Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize labels Apr 8, 2026

github-actions bot added [JS Package] Charts [JS Package] Number Formatters [JS Package] Social Previews [Status] In Progress [Tests] Includes Tests RNA labels Apr 8, 2026

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 8, 2026

ederrengifo force-pushed the experiment/social-ui-fixes branch from a1435b6 to ff17582 Compare April 8, 2026 20:06

ederrengifo added 4 commits April 8, 2026 15:57

Social: Update social media preview mockups to match current platform…

22010fc

… UIs

Add changelog entries for social preview updates

24a6cfb

Fix ESLint unused import and TypeScript type mismatch

2af5753

changelog

ad0ae4e

ederrengifo force-pushed the experiment/social-ui-fixes branch from 689c41d to ad0ae4e Compare April 8, 2026 21:00

ederrengifo added 5 commits April 8, 2026 16:36

Fix ESLint no-explicit-any in charts leaderboard component

b805a66

Add tests for Instagram and Facebook post preview components

6f94a02

Fix type errors and improve test coverage for social previews

afab7d4

Add tests for useImage hook and Instagram aspect ratio clamping

ad898da

Fix unnecessary act wrapper in Instagram test

1f7b0f0

gmjuhasz requested changes Apr 9, 2026

View reviewed changes

ederrengifo added 4 commits April 9, 2026 10:06

Remove build cache file from number-formatters

be3b4ee

Remove second build cache file from number-formatters

73efa76

Restore translated time string in LinkedIn preview

dabe1e7

Restore Account Name fallback in LinkedIn preview header

479a6d7

ederrengifo added 3 commits April 9, 2026 10:16

Restore connection degree indicator in LinkedIn preview header

e87a8f2

Address reviewer feedback: fix SEO regression, remove !important, cle…

43b061d

…an dead CSS, restore min-width

Remove unrelated files accidentally included in previous commit

6bffc3a

github-actions bot added [Plugin] Super Cache A fast caching plugin for WordPress. Docker E2E Tests labels Apr 9, 2026

Conversation

ederrengifo commented Apr 8, 2026

Proposed changes

Scrolling adjusment

Adjustments in preview mockups

Other information

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

Uh oh!

github-actions bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

gmjuhasz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ederrengifo Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ederrengifo commented Apr 9, 2026

Uh oh!

ederrengifo commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Apr 8, 2026 •

edited

Loading

github-actions bot commented Apr 8, 2026 •

edited

Loading

jp-launch-control bot commented Apr 8, 2026 •

edited

Loading

ederrengifo Apr 9, 2026 •

edited

Loading