fix(upload): publish stems sequentially after parent track - #14547
Merged
Conversation
When uploading a contest track + stems, publishParentTrack() and publishStems() ran concurrently via Promise.all. This caused stems to be published before the parent track was confirmed on-chain, so every publishStem API call failed. The UI showed red ⚠ error icons on all stem rows even though the upload actually succeeded. Reproducible on: Burko contest, Andrew Lux contest, Audius Summer Cypher Vol 2. Fix: await publishParentTrack() first, then await publishStems(). This ensures the parent track is on-chain before any stem references it, eliminating the race condition.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When uploading a contest track + stems simultaneously on audius.co, the UI gets permanently stuck on "Uploading Your Track" with red ⚠ error icons on every stem and the track itself — even though the upload succeeded (the contest page works after navigating away).
Reproducible on: Burko contest, Andrew Lux contest, Audius Summer Cypher Vol 2.
Root cause
In
usePublishTracks.ts,publishParentTrack()andpublishStems()were running concurrently viaPromise.all:publishStemsreceived thetrackId(generated bysdk.tracks.generateTrackId()) and passed it to each stem publish call — but because both ran in parallel, the stems were being published before the parent track was confirmed on-chain. EverypublishStemAPI call failed as a result, dispatchingProgressStatus.ERRORfor each stem row.Fix
Await the parent track first, then publish stems:
This ensures the parent track is on-chain before any stem references it, eliminating the race condition.