-
-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(dashboard): fix WebUI dark mode rendering and multiple UI interaction bugs #7173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| // highlight.js dark mode overrides | ||
| // Scoped to the dark Vuetify theme so the default github.css light styles work in light mode. | ||
| .v-theme--PurpleThemeDark { | ||
| .hljs { | ||
| background: transparent; | ||
| color: #adbac7; | ||
| } | ||
|
|
||
| .hljs-doctag, | ||
| .hljs-keyword, | ||
| .hljs-meta .hljs-keyword, | ||
| .hljs-template-tag, | ||
| .hljs-template-variable, | ||
| .hljs-type, | ||
| .hljs-variable.language_ { | ||
| color: #f47067; | ||
| } | ||
|
|
||
| .hljs-title, | ||
| .hljs-title.class_, | ||
| .hljs-title.class_.inherited__, | ||
| .hljs-title.function_ { | ||
| color: #dcbdfb; | ||
| } | ||
|
|
||
| .hljs-attr, | ||
| .hljs-attribute, | ||
| .hljs-literal, | ||
| .hljs-meta, | ||
| .hljs-number, | ||
| .hljs-operator, | ||
| .hljs-selector-attr, | ||
| .hljs-selector-class, | ||
| .hljs-selector-id, | ||
| .hljs-variable { | ||
| color: #6cb6ff; | ||
| } | ||
|
|
||
| .hljs-meta .hljs-string, | ||
| .hljs-regexp, | ||
| .hljs-string { | ||
| color: #96d0ff; | ||
| } | ||
|
|
||
| .hljs-built_in, | ||
| .hljs-symbol { | ||
| color: #f69d50; | ||
| } | ||
|
|
||
| .hljs-code, | ||
| .hljs-comment, | ||
| .hljs-formula { | ||
| color: #768390; | ||
| } | ||
|
|
||
| .hljs-name, | ||
| .hljs-quote, | ||
| .hljs-selector-pseudo, | ||
| .hljs-selector-tag { | ||
| color: #8ddb8c; | ||
| } | ||
|
|
||
| .hljs-subst { | ||
| color: #adbac7; | ||
| } | ||
|
|
||
| .hljs-section { | ||
| color: #316dca; | ||
| font-weight: bold; | ||
| } | ||
|
|
||
| .hljs-bullet { | ||
| color: #eac55f; | ||
| } | ||
|
|
||
| .hljs-emphasis { | ||
| color: #adbac7; | ||
| font-style: italic; | ||
| } | ||
|
|
||
| .hljs-strong { | ||
| color: #adbac7; | ||
| font-weight: bold; | ||
| } | ||
|
|
||
| .hljs-addition { | ||
| color: #b4f1b4; | ||
| background-color: #1b4721; | ||
| } | ||
|
|
||
| .hljs-deletion { | ||
| color: #ffd8d3; | ||
| background-color: #78191b; | ||
| } | ||
|
|
||
| // markstream-vue dark mode variables override | ||
| // markstream-vue expects a `.dark` ancestor to activate its dark palette, | ||
| // but Vuetify uses `.v-theme--PurpleThemeDark` instead. | ||
| .markstream-vue { | ||
| --border: 217.2 32.6% 17.5%; | ||
| --background: 222.2 84% 4.9%; | ||
| --foreground: 210 40% 98%; | ||
| --secondary: 217.2 32.6% 17.5%; | ||
| --muted: 217.2 32.6% 17.5%; | ||
| --muted-foreground: 215 20.2% 65.1%; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为了保持主题一致性和可维护性,建议将硬编码的颜色值
#1e1e2e替换为 Vuetify 主题变量。例如rgb(var(--v-theme-surface))。如果这个颜色在多处使用且与现有主题变量都不同,最好在
src/theme/DarkTheme.ts中将其定义为一个新的颜色变量,然后在所有使用到的地方统一调用。此建议同样适用于第 181 行。