fix: remove description siblings from $ref fields - #28
Closed
evantahler wants to merge 2 commits into
Closed
Conversation
oapi-codegen v2.6.0 silently drops $ref properties that have description siblings on certain schemas. In OpenAPI 3.0.x, sibling keywords next to $ref are ignored per spec anyway. Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
descriptionsiblings from$reffields onToolInfo.metadataandToolVersionInfo.metadata$refproperties that havedescriptionsiblings, causingToolInfo.metadatato be missing from generated Go code$refare ignored per spec, so these descriptions had no effect anywayContext
Follow-up to #26. Discovered during Go codegen in ArcadeAI/monorepo#517.
Made with Cursor