Conversation
…ions - Remove redundant esp32 board string (variant + flash_size already present) - Add web_server version: 3 to Core.yaml - Remove platformio_options board_build.flash_mode from both device YAMLs - Remove legacy BLE wifi on_connect/on_disconnect hooks from PUMP-1.yaml
[esphome] Modernise board spec, web server v3, remove legacy options
[version] Add ESPHome and Apollo firmware version sensors
[wifi-info] Add IP address text sensor
Adds two new optional config switches (off by default): - Invert Water Logic: flips input sensor meaning so DRY = destination low = start pump, WET = destination full = stop pump - Auto Refill: automatically triggers pumpUntilFull when input sensor goes dry in inverted mode Resolves #22
When stop_pump_when_full is ON, the output sensor already handles full detection. Skip the inverted-mode input sensor stop to prevent the pump from stopping as water passes the low-level sensor on the way to full.
Bump version to 26.3.2.1
[cpap] Add invert water logic and auto refill for CPAP filling use case
The sensor was showing "unknown" because update_interval: never prevents the lambda from ever firing. Removing it allows the default 60s periodic update to publish the version string.
Fix Apollo Firmware Version sensor showing unknown
Per ESPHome dev feedback: the version is a compile-time constant, so publish it once on_boot rather than using a lambda with periodic updates.
Add text_sensor.template.publish for apollo_firmware_version at priority 500 to PUMP-1_Minimal for dashboard import users.
Fix: publish firmware version once on boot instead of polling
Adds a homeassistant.action logbook.log call in the fluid_input_sensor on_release handler so that HA logbook records when the pump is triggered automatically by the CPAP auto refill + invert water logic mode.
[cpap] Add logbook entry for auto refill trigger
Replaces the homeassistant.action logbook.log approach from #32 with an ESPHome event entity, which surfaces natively in the HA logbook without requiring API actions to be enabled on the device. Fires three event types: - auto_refill_triggered: CPAP auto refill + invert water logic triggers pump - pump_started: pump_control turns on and conditions are met - pump_stopped: pump_control turns off
pump_start_time is only set when the pump actually starts successfully. Checking != 0 before logging and emitting pump_stopped prevents false logbook entries when a start is rejected and switch.turn_off is called from the else branch of on_turn_on.
…tries ESPHome event entities show only a generic 'detected an event' string in the HA logbook. Replaces the Pump Activity event entity with a Last Pump Action text sensor whose state changes (Auto Refill Triggered, Pump Started, Pump Stopped) appear verbatim in the HA logbook.
[cpap] Add Last Pump Action text sensor for HA logbook
…switches Renames the switch name, id, and all 4 condition references from invert_water_logic to tank_refill_mode for clarity. Adds on_turn_on/on_turn_off handlers to auto-configure related switches: - Turn ON: Stop Pump When Output Wet → ON, Stop Pump When Input Dry → OFF - Turn OFF: Stop Pump When Output Wet → OFF, Stop Pump When Input Dry → ON
…de state on_turn_on/on_turn_off only fire when explicitly toggled, not on boot restore. Adds a priority -20 on_boot handler that reads tank_refill_mode and sets stop_pump_when_full and stop_pump_when_dry accordingly so all three switches are in sync after every reboot.
…witches [ux] Rename Invert Water Logic to Tank Refill Mode + auto-configure switches
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 15 minutes and 54 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version: 26.3.2.1
What does this implement/fix?
Merges beta into main for the 26.3.2.1 release. Changes include:
pumpUntilFullwhen input sensor goes dry in Tank Refill Mode; auto-toggles with Tank Refill Modewifi_infoplatformTypes of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified: