Repository navigation
Conversation
Reviewer's GuideConfigurationPass the optional mobile OIDC client ID through both Compose configurations so Compose users can configure it.
DocumentationDocument the mobile client ID and explain how to configure a separate public OIDC client for native sign-in.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for your first pull request to Wardrowbe! Please make sure you've read the CONTRIBUTING guide, especially the PR title format section. A maintainer will review this soon. |
Linked issuesChecked at commit ada109a #335 [Feature]: Support Separate OIDC Client IDs for Web and Native Mobile Apps · 1 of 1 met
|
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. When configured, the backend can accept ID tokens addressed to the separate mobile client, changing which client audiences are trusted for sign-in. Reverting stops that acceptance, but any unauthorized access enabled while it was active cannot be undone by the revert.
Description
The native mobile app may sign in with its own OIDC client flow (Authorization Code with PKCE). The backend already supports a separate mobile client via OIDC_MOBILE_CLIENT_ID. But the variable was only listed in the k8s configmap, so compose users couldn't set it and nobody could find it.
Related Issue
Fixes #335
Type of Change
Checklist
Testing
not applicable
Remark
This is my first pull request in quite a while - happy to contribute!
Summary by Sourcery
Document and expose the separate public OIDC client setting for native mobile authentication across supported deployment configurations.
Enhancements:
Build:
Documentation: