Skip to content

docs: add OIDC_MOBILE_CLIENT_ID and pass it through in compose - #338

Open
philippst wants to merge 1 commit into
Anyesh:mainfrom
philippst:fix/mobile-oidc-env
Open

philippst wants to merge 1 commit into
Anyesh:mainfrom
philippst:fix/mobile-oidc-env

Conversation

@philippst

@philippst philippst commented Nov 13, 2026 •

Copy link
Copy Markdown

Description

The native mobile app may sign in with its own OIDC client flow (Authorization Code with PKCE). The backend already supports a separate mobile client via OIDC_MOBILE_CLIENT_ID. But the variable was only listed in the k8s configmap, so compose users couldn't set it and nobody could find it.

Related Issue

Fixes #335

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/CD or build changes

Checklist

  • I have read the CONTRIBUTING guide
  • My code follows the project's coding style
  • I have added tests that prove my fix/feature works
  • New and existing tests pass locally
  • I have updated documentation as needed
  • My changes don't introduce new warnings or errors

Testing

not applicable

Remark

This is my first pull request in quite a while - happy to contribute!

Summary by Sourcery

Document and expose the separate public OIDC client setting for native mobile authentication across supported deployment configurations.

Enhancements:

  • Document the separate public OIDC client configuration for native mobile authentication, including its fallback behavior and provider setup guidance.

Build:

  • Pass OIDC_MOBILE_CLIENT_ID through both development and production Docker Compose configurations.

Documentation:

  • Add OIDC_MOBILE_CLIENT_ID to the environment variable reference and Kubernetes configuration guidance.

@sourcery-ai

sourcery-ai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Configuration

Pass the optional mobile OIDC client ID through both Compose configurations so Compose users can configure it.

  • docker-compose.prod.yml L93
  • docker-compose.yml L87

Documentation

Document the mobile client ID and explain how to configure a separate public OIDC client for native sign-in.

  • README.md L302, L369-374
  • k8s/README.md L242-244

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your first pull request to Wardrowbe! Please make sure you've read the CONTRIBUTING guide, especially the PR title format section. A maintainer will review this soon.

@github-actions github-actions Bot added the docker Pull requests that update docker code label Nov 13, 2026
@sourcery-ai

sourcery-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Linked issues

Checked at commit ada109a

#335 [Feature]: Support Separate OIDC Client IDs for Web and Native Mobile Apps · 1 of 1 met

# Requirement Status Notes
1 Support separate OIDC client IDs for web and native mobile apps using the same issuer/user pool. ✅ Met The backend exposes the mobile client ID to the native app and accepts tokens for either client; this change passes the setting through both Compose configurations and documents the public-client setup.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. When configured, the backend can accept ID tokens addressed to the separate mobile client, changing which client audiences are trusted for sign-in. Reverting stops that acceptance, but any unauthorized access enabled while it was active cannot be undone by the revert.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker Pull requests that update docker code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Support Separate OIDC Client IDs for Web and Native Mobile Apps

2 participants