Repository navigation
Conversation
Add a full Spanish (Spain) catalogue and register es alongside the existing languages, including the AI description language. English stays the default. Co-authored-by: Carmonacu <Carmonacu@users.noreply.github.com>
|
Thanks for your first pull request to Wardrowbe! Please make sure you've read the CONTRIBUTING guide, especially the PR title format section. A maintainer will review this soon. |
Reviewer's GuideData structuresAdd the Spanish message catalogue and register Spanish in the backend and frontend locale data so the application recognizes it alongside the existing languages.
ImplementationAdd Spanish with informal tú phrasing to the language instructions used for AI-generated item descriptions.
DocumentationUpdate the contributor guide and README to state that the application supports nine languages, including Spanish.
TestsExtend backend tests to verify Spanish is selected for localized AI descriptions and accepted as a user locale.
Add Spanish expectations for localized date displays, including the relative-date label.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="frontend/lib/i18n/locales.ts" line_range="23" />
<code_context>
fr: { name: 'French', nativeName: 'Français', dir: 'ltr' },
de: { name: 'German', nativeName: 'Deutsch', dir: 'ltr' },
it: { name: 'Italian', nativeName: 'Italiano', dir: 'ltr' },
+ es: { name: 'Spanish', nativeName: 'Español', dir: 'ltr' },
};
</code_context>
<issue_to_address>
**Spanish auth screens show English**
When spanish is selected and authentication messages are loaded, or the locale-catalog parity test runs, `loadMessages` cannot load `messages/es/auth.json` because the Spanish auth keys are missing, so it falls back to English authentication messages and the parity test fails.
Add the Spanish `auth` catalog with the keys from `en/auth.json`.
</issue_to_address>Sourcery assessment
Needs a human reviewer. 1 finding to address first, and for Spanish users, the AI description prompt can produce Spanish text that is saved with an item; a bad translation or prompt could leave incorrect descriptions after reverting. Those records are bounded and can be edited or regenerated.
Blocking findings: frontend/lib/i18n/locales.ts:23
Co-authored-by: Carmonacu <Carmonacu@users.noreply.github.com>
Co-authored-by: Carmonacu <Carmonacu@users.noreply.github.com>
Add a full Spanish (Spain) catalogue and register es alongside the existing languages, including the AI description language. English stays the default.
Description
Related Issue
Type of Change
Checklist
Testing
Test Environment
Tests Performed
Screenshots (if applicable)
Additional Notes
Summary by Sourcery
Add Spanish localization across the application while retaining English as the default language.
New Features:
Enhancements:
Tests: