Skip to content

Add CI verification tests and guidelines#1

Merged
menny merged 13 commits intomainfrom
feat/ci-verification-tests
Apr 9, 2026
Merged

Add CI verification tests and guidelines#1
menny merged 13 commits intomainfrom
feat/ci-verification-tests

Conversation

@menny
Copy link
Copy Markdown
Member

@menny menny commented Apr 4, 2026

  • Update AGENTS.md with new testing and dependency pinning guidelines
  • Implement Kotlin verification test using JUnit 5
  • Implement TypeScript verification test using Node.js native test runner
  • Configure Bazel targets for all verification tests
  • Use copy_to_bin for configuration file hermeticity in Bazel

menny added 5 commits April 4, 2026 15:02
- Update AGENTS.md with new testing and dependency pinning guidelines
- Implement Kotlin verification test using JUnit 5
- Implement TypeScript verification test using Node.js native test runner
- Configure Bazel targets for all verification tests
- Use copy_to_bin for configuration file hermeticity in Bazel
- Use java_binary for ktlint to handle JAR execution correctly
- Use rlocation in ktlint wrapper to find JAR reliably
- Update prettier binary with config paths relative to runfiles root
- Adopt AnySoftKeyboard pattern for hermetic config file access
- Robust runfiles resolution in ktlint_wrapper.sh
- Fixed Kotlin formatting write-back to disk
- Verified all languages (TS, Kotlin, YAML, JSON) format correctly via //:format
- Finalized CI verification tests for TS and Kotlin
- Use rules_shell launcher for ktlint_wrapper.sh to simplify runfiles access
- Add robust JAR discovery logic in wrapper
- Fix Kotlin formatting write-back by ensuring java -jar uses absolute JAR path
- Verified TS, Kotlin, and YAML formatting locally with //:format
@AnySoftKeyboard AnySoftKeyboard deleted a comment from github-actions bot Apr 5, 2026
menny added 4 commits April 5, 2026 17:18
- Fix typo in AGENTS.md ('ages 6')
- Update ktlint_wrapper.sh to correctly pass extra arguments (check/fix flags)
- Remove unused aspect_rules_jest from MODULE.bazel
- Ensure Kotlin formatting correctly writes back to disk using rlocation resolution
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

  • [Risk] [.github/workflows/review.yml:28] We are removing the reviewer_github_token from the Cassandra AI Review job. If the action requires this token to authenticate and post comments back to the Pull Request, this change will break the automated review feedback loop. We should ensure the action can operate with the default GITHUB_TOKEN permissions before removing this secret.
  • [Maintenance] [backend/BUILD.bazel:15-18] The backend_test target uses ConsoleLauncher with a hardcoded --select-package septima argument. This is fragile; any tests added to sub-packages (e.g., septima.auth) or different package structures in the future will be silently ignored by the test runner. We should configure the test runner to discover all tests within the srcs of the target automatically.
  • [Maintenance] [tools/prettier_filter_links.sh:18] The fallback path for PRETTIER_BIN hardcodes the _main workspace name. Since our MODULE.bazel defines the module name as septima, this path may be invalid in certain Bazel environments or future versions. We should rely exclusively on the PRETTIER_BIN environment variable passed via the sh_binary and fail explicitly if it is not set, rather than attempting to guess the runfiles layout.
  • [Observation] [.editorconfig:12] We are changing the Kotlin indentation from 4 spaces (the language standard) to 2 spaces. While this is consistent with the rest of the project's move toward 2-space indentation, it may conflict with default IDE configurations for Kotlin. We should ensure all contributors update their IDE settings to prevent "format wars" in future PRs.
  • [Observation] [backend/Main.kt:2] Manual indentation change to 2 spaces. As noted in the AGENTS.md guidelines, we should generally rely on bazel run //:format (which now uses ktfmt as per tools/format/BUILD.bazel) rather than manual adjustments, but this change is correct according to the new policy.

The consolidation of agent instructions via symlinks for CLAUDE.md and GEMINI.md is a great improvement for maintainability.

❌ Rejected

menny added 3 commits April 7, 2026 12:59
- Filter out symbolic links in prettier_wrapper.sh and ktlint_wrapper.sh
- Ensure wrappers use robust discovery logic for binaries
- Fix 'explicitly specified pattern is a symbolic link' error from Prettier
- Verified all formatters pass with symlinks present
- Use java_binary for ktlint in tools/format
- Add lightweight prettier.sh wrapper to filter out symlinks
- Update tools/lint/linters.bzl to latest aspect factory functions
- Remove old complex wrapper scripts
- Verified formatting write-back and all tests passing
@menny menny force-pushed the feat/ci-verification-tests branch 2 times, most recently from b03b884 to b22b24b Compare April 9, 2026 11:52
@menny menny force-pushed the feat/ci-verification-tests branch from 0f5257b to d94dd3d Compare April 9, 2026 15:00
@menny menny merged commit 893c562 into main Apr 9, 2026
2 checks passed
@menny menny deleted the feat/ci-verification-tests branch April 9, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant