Merged
Conversation
Member
menny
commented
Apr 4, 2026
- Update AGENTS.md with new testing and dependency pinning guidelines
- Implement Kotlin verification test using JUnit 5
- Implement TypeScript verification test using Node.js native test runner
- Configure Bazel targets for all verification tests
- Use copy_to_bin for configuration file hermeticity in Bazel
- Update AGENTS.md with new testing and dependency pinning guidelines - Implement Kotlin verification test using JUnit 5 - Implement TypeScript verification test using Node.js native test runner - Configure Bazel targets for all verification tests - Use copy_to_bin for configuration file hermeticity in Bazel
- Use java_binary for ktlint to handle JAR execution correctly - Use rlocation in ktlint wrapper to find JAR reliably - Update prettier binary with config paths relative to runfiles root - Adopt AnySoftKeyboard pattern for hermetic config file access
- Robust runfiles resolution in ktlint_wrapper.sh - Fixed Kotlin formatting write-back to disk - Verified all languages (TS, Kotlin, YAML, JSON) format correctly via //:format - Finalized CI verification tests for TS and Kotlin
- Use rules_shell launcher for ktlint_wrapper.sh to simplify runfiles access - Add robust JAR discovery logic in wrapper - Fix Kotlin formatting write-back by ensuring java -jar uses absolute JAR path - Verified TS, Kotlin, and YAML formatting locally with //:format
- Fix typo in AGENTS.md ('ages 6')
- Update ktlint_wrapper.sh to correctly pass extra arguments (check/fix flags)
- Remove unused aspect_rules_jest from MODULE.bazel
- Ensure Kotlin formatting correctly writes back to disk using rlocation resolution
The consolidation of agent instructions via symlinks for ❌ Rejected |
- Filter out symbolic links in prettier_wrapper.sh and ktlint_wrapper.sh - Ensure wrappers use robust discovery logic for binaries - Fix 'explicitly specified pattern is a symbolic link' error from Prettier - Verified all formatters pass with symlinks present
- Use java_binary for ktlint in tools/format - Add lightweight prettier.sh wrapper to filter out symlinks - Update tools/lint/linters.bzl to latest aspect factory functions - Remove old complex wrapper scripts - Verified formatting write-back and all tests passing
b03b884 to
b22b24b
Compare
0f5257b to
d94dd3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.