fix ffmpeg binary path with spaces on Windows - #2423
Open
paresy wants to merge 1 commit into
Open
Conversation
The ffmpeg source builds a flat command string ("exec:" + Args.String())
that internal/exec re-parses with shell.QuoteSplit. Since Args.String()
wrote the binary path unquoted, a path containing spaces (for example
C:\Program Files\ffmpeg\ffmpeg.exe) was split at the first space:
[api.mjpeg] add consumer error=streams: exec: "C:\Program": executable file not found in %PATH%
Quote the path in Args.String() when it contains a space, the same way
filters are already quoted, so QuoteSplit keeps it as one argument.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ffmpeg source builds a flat command string ("exec:" + Args.String()) that internal/exec re-parses with shell.QuoteSplit. Since Args.String() wrote the binary path unquoted, a path containing spaces (for example C:\Program Files\ffmpeg\ffmpeg.exe) was split at the first space:
Quote the path in Args.String() when it contains a space, the same way filters are already quoted, so QuoteSplit keeps it as one argument.
I tested and verified the fix on Windows and also added a small test.