Add optional pacing for bursty Xiaomi CS2 video - #2411
Draft
RuiFG wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
pacingparameter to Xiaomi MISS/CS2 sourcesWhy
Some Xiaomi CS2 cameras deliver video in bursts. Downstream consumers such as HomeKit may render those bursts as periodic stalls. Pacing the access units smooths delivery, but anchoring each frame to the timer's actual wake-up time caused normal scheduler overshoot to accumulate during long-running prebuffer sessions. In testing, restarting go2rtc immediately reset roughly ten seconds of built-up delay to about two seconds.
The pacing option remains disabled unless a source explicitly sets it, for example
pacing=120.Validation
go test ./pkg/xiaomi/miss ./pkg/xiaomi/miss/cs2xiaomi.camera.083ac1test stream through go2rtc, Scrypted, and HomeKit