Fix Xiaomi CS2 audio payload writes - #2406
Draft
RuiFG wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
WritePacketallocates space forhdrSize + len(payload), but the secondcopyusedhdragain. As a result, the camera received encrypted media-header bytes followed by zero padding instead of the encrypted Opus payload, which produced extremely loud static during two-way audio.User impact
This restores the speaker payload for Xiaomi cameras using the MISS/CS2 transport. The fix was verified end-to-end with
xiaomi.camera.083ac1on go2rtc 1.9.14 through Scrypted and HomeKit; two-way audio works after applying this change.Fixes #2175.
Validation
go test ./pkg/xiaomi/miss/cs2go test ./pkg/xiaomi/miss/...go build -trimpath .xiaomi.camera.083ac1go test ./...was also run on Windows; unrelated existing failures remain in FFmpeg expectations and platform/build-tag-dependent packages. The focused Xiaomi CS2 tests pass.