Bound Sonoff debug logging - #1853
Open
aferende wants to merge 1 commit into
Open
Conversation
aferende
marked this pull request as ready for review
August 2, 2026 07:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The optional Sonoff debug view currently raises the integration logger to
DEBUGand lets the protocol logger propagate to Home Assistant's raw log stream. Long-running debug mode can therefore write high-frequency Cloud/Local protocol traces to Home Assistant logs and, when configured, associated system-log/recorder processing.This change keeps the existing bounded in-memory debug page while preventing protocol
DEBUGrecords from propagating to Home Assistant's root handlers.WARNINGandERRORrecords are still explicitly forwarded, so actionable failures remain visible.Changes
LogRecord.levelnoas a side effect of debug capture.Impact
This makes temporary debugging safer for production Home Assistant installations: diagnostics remain available at the random debug-view URL, but protocol traffic no longer grows the raw log stream continuously.
Validation
python3 -m compileall -q custom_components testsgit diff --checkThe regression test is included; the local environment used for this contribution does not have the project's pytest/Home Assistant test dependencies installed.
No configuration, credentials, device identifiers, or private-network information are included.