Accept GH_TOKEN in vast GitHub token resolution - #25
Draft
Al-does wants to merge 1 commit into
Draft
Conversation
Vast provisioning previously read GITHUB_TOKEN only, while Cloud Agents and RunPod paths inject GH_TOKEN. Align vast with the shared resolution order: CLI flag, GH_TOKEN, GITHUB_TOKEN, then gh auth token. Bootstrap normalizes GH_TOKEN onto GITHUB_TOKEN for clone/push, and redaction covers both env var names. Co-authored-by: Alex Vardakostas <Al-does@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vast provisioning previously resolved GitHub credentials from
GITHUB_TOKENonly. Cloud Agents and RunPod paths injectGH_TOKEN, so vast--self-destructflows failed on agents that only hadGH_TOKENset.This aligns vast with the shared resolution order used elsewhere in
devops/:--github-tokenGH_TOKENGITHUB_TOKENgh auth tokenChanges
devops/vast/provision.py: updatedresolve_github_token()and user-facing help/error textdevops/vast/bootstrap.sh: normalizeGH_TOKEN→GITHUB_TOKENon the remote boxdevops/vast/redaction.pyandself_destruct.py: redactGH_TOKENin logs/metadataTesting