Make path traversal containment check case-insensitive#299
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
tomaisthorpe
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the user-input containment check in path traversal detection case-insensitive, matching the fix applied to the Node.js firewall in AikidoSec/firewall-node#1047.
Problem: On case-insensitive filesystems (macOS APFS, Windows NTFS), an attacker can submit a path like
/ETC/PASSWDwhich resolves to/etc/passwd. The detection checkfilePath.contains(userInput)was case-sensitive, so/ETC/PASSWDwould not be found in/etc/passwdand traversal would go undetected.Fix: Changed
filePath.contains(userInput)tofilePath.toLowerCase().contains(userInput.toLowerCase()). Note thatstartsWithUnsafePathalready lowercases both sides before comparing, so no change was needed there.See: AikidoSec/firewall-node#1047
Summary by Aikido
🐛 Bugfixes
More info