Skip to content

Trim user input before sending to detectSQLInjection #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitterpanda63 merged 1 commit into from
Jun 1, 2026
Merged

Trim user input before sending to detectSQLInjection #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vulnerabilities/sqlinjection/detect_sql_injection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const (
func detectSQLInjection(query string, userInput string, dialect int) int {
// Lowercase versions of query and user input
queryLowercase := strings.ToLower(query)
userInputLowercase := strings.ToLower(userInput)
userInputLowercase := strings.TrimSpace(strings.ToLower(userInput))

if shouldReturnEarly(queryLowercase, userInputLowercase) {
return sqlInjectionSafe
Expand Down
6 changes: 6 additions & 0 deletions vulnerabilities/sqlinjection/detect_sql_injection_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@ func TestIsSQLInjection(t *testing.T) {
first_name,
last_name
FROM users WHERE email_lowercase = '' or 1=1 -- a',`, "' OR 1=1 -- a"},

// it detects injection when user input has trailing whitespace (trimmed by DB driver)
{
"INSERT INTO pets (name, owner) VALUES ('x', 'dummy'), ('injected', 'hacker'); --', 'owner')",
"x', 'dummy'), ('injected', 'hacker'); -- ",
},
}

for _, tt := range tests {
Expand Down
Loading