Add profile name functionality to heartbeat and settings#189
Open
thalesac wants to merge 3 commits intoActivityWatch:masterfrom
Open
Add profile name functionality to heartbeat and settings#189thalesac wants to merge 3 commits intoActivityWatch:masterfrom
thalesac wants to merge 3 commits intoActivityWatch:masterfrom
Conversation
This change enhances user experience by allowing users to set a custom profile name, which can improve the identification of user sessions and preferences. Without this change, users would lack a personalized touch in their interactions, potentially leading to confusion when managing multiple profiles. * Introduced `getDisplayProfileName` to retrieve the profile name in the heartbeat function. * Added a new input field for custom profile name in the settings interface. * Implemented `generateProfileIdentifier` Signed-off-by: Thales Ceolin <[email protected]>
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 116d29b in 55 seconds. Click for details.
- Reviewed
220lines of code in6files - Skipped
0files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/background/heartbeat.ts:31
- Draft comment:
Including profileName in heartbeat data is a useful addition for session tracking. Ensure getDisplayProfileName returns an appropriate fallback when no custom name is set. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. src/background/main.ts:38
- Draft comment:
initializeProfileIdentifier is straightforward. Consider adding error handling around generateProfileIdentifier to catch potential failures. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. src/settings/index.html:54
- Draft comment:
The Profile Name input field is clearly implemented. Consider adding a maxlength attribute to limit input length and mitigate potential abuse. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. src/settings/main.ts:39
- Draft comment:
Custom profile name handling on save works well. It might be beneficial to add client-side validation (e.g., maximum length) beyond the HTML pattern. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
5. src/storage.ts:140
- Draft comment:
getDisplayProfileName provides a sensible fallback using a truncated profile identifier when no custom name is set. Verify that this fallback meets the display requirements. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
6. vite.config.ts:32
- Draft comment:
The custom plugin for copying the logo is a neat addition. Consider whether a missing logo file should trigger an error if it's critical for branding. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_RR8zl8nGDXoZDmb7
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
BelKed
reviewed
Jun 11, 2025
The removal of the custom plugin for copying the logo file streamlines the Vite configuration, reducing unnecessary complexity. Without this change, the build process could have included redundant steps that may lead to confusion or errors in future maintenance. * Eliminated the custom plugin that copied the logo file from the media directory to the build directory. * Removed imports for file system operations and path resolution that were no longer necessary. Signed-off-by: Thales Ceolin <[email protected]>
BelKed
suggested changes
Jun 13, 2025
This change enhances the user experience by providing visibility into the user's profile directly within the popup. Without this addition, users would lack important contextual information, potentially leading to confusion regarding their current profile status. * Introduced a new table row in the HTML to display the user's profile. * Integrated the `getDisplayProfileName` function to fetch the profile name from storage. * Updated the `renderStatus` function to populate the profile name in the newly added HTML element. Signed-off-by: Thales Ceolin <[email protected]>
Author
|
@BelKed just updated with your request. THanks for looking into it! |
Author
|
friendly bump in case this is forgotten @BelKed |
Contributor
|
I'm not a repo owner/maintainer, @ErikBjare is 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Allow users to set a custom profile name, which can improve the identification of user sessions and preferences. E.g.
Work profile for client X, Personal, etc.
getDisplayProfileNameto retrieve the profile name in the heartbeat function.generateProfileIdentifierImportant
Adds custom profile name functionality to heartbeat and settings, including UI input and storage handling.
profileNameto heartbeat data inheartbeat.tsusinggetDisplayProfileName().main.tswithgenerateProfileIdentifier().profileNameinindex.html.profileNameinmain.ts.getCustomProfileName,setCustomProfileName, andgetDisplayProfileNameinstorage.ts.generateProfileIdentifierto create unique profile identifiers.vite.config.tsto copy logo files during build.This description was created by
for 116d29b. You can customize this summary. It will automatically update as commits are pushed.